Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2872363002: Upstream service worker navigation tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker navigation tests to WPT **navigation-redirect** Update existing assertions to adhere to the latest version of the Fetch specification. The relevant change from that document [1] is explained as follows: > [...] > * Only when redirects are automatically followed should we set the > skip-service-worker flag, otherwise we negatively affect navigations. > [...] (Note that the Request's "skip-service-worker flag" was subsequently re-implemented as "service-workers mode" in [2].) Insert two additional tests introduced by Chromium project commit cb6838f5badc8c2df03f387f4aa726629214179a, whose message reads: > Make no-location redirect response to be "opaque redirect" when > redirect mode is manual. > > According to the spec, even if location header is not set, we should > treat the redirect response as "opaqueredirect" if the redirect mode > of the fetch request is "manual". > > This behavior was changed by this commit on the spec. > https://github.com/whatwg/fetch/commit/3e501f29eceff41eb81c60fb9937e33e23cf5492 Remove the "-expectations.txt" file for this test since Chromium passes the corrected version. Remove the Chromium-specific version of the test. **navigation-redirect-body** Re-locate test file to Web Platform Test directory for eventual automated upstreaming. Simplify test body by constructing necessary DOM declaratively with HTML. Schedule frame removal to occur following test completion. **navigation-redirect-to-http** Re-locate test file to Web Platform Test directory for eventual automated upstreaming. Prefer the generalized `redirect.py` script over a test-specific script defining equivalent functionality. Correct typo in test title. [1] https://github.com/whatwg/fetch/commit/ec6f5ef5f99cb6b0dd6c701b49791810fb380b04 [2] https://github.com/whatwg/fetch/commit/d41c2380dc828e7a23c6196a344b42b2d0e9beec BUG=688116 R=mek@chromium.org Review-Url: https://codereview.chromium.org/2872363002 Cr-Commit-Position: refs/heads/master@{#472332} Committed: https://chromium.googlesource.com/chromium/src/+/e5241c1ac5cf149707ce97b0a877e0529bd61de2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -832 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect-body.https.html View 2 chunks +16 lines, -20 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect-to-http.https.html View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html View 5 chunks +23 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-body.py View 1 chunk +9 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-body-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-out-scope.py View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope1.py View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope2.py View 1 chunk +6 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-to-http-iframe.html View 3 chunks +5 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-to-http-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect.html View 1 chunk +0 lines, -468 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-body.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-redirect-to-http.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-body.php View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-body-worker.js View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-other-origin.html View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-out-scope.php View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-scope1.php View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-scope2.php View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http.php View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-iframe.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-to-http-worker.js View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/navigation-redirect-worker.js View 1 chunk +0 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mike3
Hi Mek, The updates to the test named "navigation-redirect" were a little tricky. I'm hoping ...
3 years, 7 months ago (2017-05-10 19:18:47 UTC) #1
Marijn Kruisselbrink
lgtm
3 years, 7 months ago (2017-05-16 20:05:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872363002/1
3 years, 7 months ago (2017-05-16 22:41:16 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:04:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5241c1ac5cf149707ce97b0a877...

Powered by Google App Engine
This is Rietveld 408576698