Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2872353005: Don't use fallback frame sinks on Android (Closed)

Created:
3 years, 7 months ago by Saman Sami
Modified:
3 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use fallback frame sinks on Android Software rendering doesn't work on Android. Just crash the renderer if it fails to initialize a CompositorFrameSink after 4 retries instead of falling back to software. BUG=721102 Review-Url: https://codereview.chromium.org/2872353005 Cr-Commit-Position: refs/heads/master@{#471454} Committed: https://chromium.googlesource.com/chromium/src/+/7a442e87ccdbce2f4f5371131d01f343b2f6eab1

Patch Set 1 #

Patch Set 2 : c #

Patch Set 3 : c #

Patch Set 4 : c #

Patch Set 5 : Disable fallback tests on android #

Total comments: 2

Patch Set 6 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M content/browser/bad_message.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor_unittest.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 45 (36 generated)
Saman Sami
3 years, 7 months ago (2017-05-12 15:00:29 UTC) #14
boliu
content/browser lgtm
3 years, 7 months ago (2017-05-12 16:14:16 UTC) #18
Saman Sami
enne: Please review content/renderer. isherman: Please review metrics.
3 years, 7 months ago (2017-05-12 16:19:29 UTC) #21
enne (OOO)
https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/render_widget_compositor.h File content/renderer/gpu/render_widget_compositor.h (right): https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/render_widget_compositor.h#newcode215 content/renderer/gpu/render_widget_compositor.h:215: // On Android, we don't use fallback frame sinks. ...
3 years, 7 months ago (2017-05-12 16:46:59 UTC) #22
Saman Sami
PTAL https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/render_widget_compositor.h File content/renderer/gpu/render_widget_compositor.h (right): https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/render_widget_compositor.h#newcode215 content/renderer/gpu/render_widget_compositor.h:215: // On Android, we don't use fallback frame ...
3 years, 7 months ago (2017-05-12 17:12:46 UTC) #27
enne (OOO)
lgtm
3 years, 7 months ago (2017-05-12 17:27:30 UTC) #28
Ilya Sherman
On 2017/05/12 16:19:29, Saman Sami wrote: > isherman: Please review metrics. It doesn't look like ...
3 years, 7 months ago (2017-05-12 21:01:56 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872353005/100001
3 years, 7 months ago (2017-05-12 21:40:22 UTC) #42
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 21:51:47 UTC) #45
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7a442e87ccdbce2f4f5371131d01...

Powered by Google App Engine
This is Rietveld 408576698