|
|
Created:
3 years, 7 months ago by Saman Sami Modified:
3 years, 7 months ago CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't use fallback frame sinks on Android
Software rendering doesn't work on Android. Just crash the renderer
if it fails to initialize a CompositorFrameSink after 4 retries instead
of falling back to software.
BUG=721102
Review-Url: https://codereview.chromium.org/2872353005
Cr-Commit-Position: refs/heads/master@{#471454}
Committed: https://chromium.googlesource.com/chromium/src/+/7a442e87ccdbce2f4f5371131d01f343b2f6eab1
Patch Set 1 #Patch Set 2 : c #Patch Set 3 : c #Patch Set 4 : c #Patch Set 5 : Disable fallback tests on android #
Total comments: 2
Patch Set 6 : Address comments #
Messages
Total messages: 45 (36 generated)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Description was changed from ========== Test ========== to ========== Don't use fallback frame sinks on Android ==========
Description was changed from ========== Don't use fallback frame sinks on Android ========== to ========== Don't use fallback frame sinks on Android BUG=721102 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't use fallback frame sinks on Android BUG=721102 ========== to ========== Don't use fallback frame sinks on Android Software rendering doesn't work on Android. Just crash the renderer if it fails to initialize a CompositorFrameSink after 4 retries instead of falling back to software. BUG=721102 ==========
samans@chromium.org changed reviewers: + boliu@chromium.org
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
content/browser lgtm
samans@chromium.org changed reviewers: + enne@chromium.org
samans@chromium.org changed reviewers: + isherman@chromium.org
enne: Please review content/renderer. isherman: Please review metrics.
https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.h (right): https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.h:215: // On Android, we don't use fallback frame sinks. (crbug.com/721102) This is a little subtle, and I think folks looking at rwc.cc won't realize that Android never has a fallback. Could you add a #ifdef OS_ANDROID and LOG_IF(FATAL, ...) in RWC::RequestNewCompositorFrameSink if fallback is true?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/re... File content/renderer/gpu/render_widget_compositor.h (right): https://codereview.chromium.org/2872353005/diff/80001/content/renderer/gpu/re... content/renderer/gpu/render_widget_compositor.h:215: // On Android, we don't use fallback frame sinks. (crbug.com/721102) On 2017/05/12 16:46:59, enne wrote: > This is a little subtle, and I think folks looking at rwc.cc won't realize that > Android never has a fallback. Could you add a #ifdef OS_ANDROID and > LOG_IF(FATAL, ...) in RWC::RequestNewCompositorFrameSink if fallback is true? Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/12 16:19:29, Saman Sami wrote: > isherman: Please review metrics. It doesn't look like you need my review =)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by samans@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org Link to the patchset: https://codereview.chromium.org/2872353005/#ps100001 (title: "Address comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494625148048260, "parent_rev": "03635b38e709b9b8ef610cb955c376bbc8bcfde1", "commit_rev": "7a442e87ccdbce2f4f5371131d01f343b2f6eab1"}
Message was sent while issue was closed.
Description was changed from ========== Don't use fallback frame sinks on Android Software rendering doesn't work on Android. Just crash the renderer if it fails to initialize a CompositorFrameSink after 4 retries instead of falling back to software. BUG=721102 ========== to ========== Don't use fallback frame sinks on Android Software rendering doesn't work on Android. Just crash the renderer if it fails to initialize a CompositorFrameSink after 4 retries instead of falling back to software. BUG=721102 Review-Url: https://codereview.chromium.org/2872353005 Cr-Commit-Position: refs/heads/master@{#471454} Committed: https://chromium.googlesource.com/chromium/src/+/7a442e87ccdbce2f4f5371131d01... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/7a442e87ccdbce2f4f5371131d01... |