Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2872353003: Remove histograms for system IPCs returning NPEs. (Closed)

Created:
3 years, 7 months ago by pauljensen
Modified:
3 years, 7 months ago
Reviewers:
Steven Holte, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove histograms for system IPCs returning NPEs. The histograms aren't serving an important purpose anymore. Leave in code to retry as this does help sometimes. Catch the NPE to avoid crashing. BUG=592131 R=xunjieli@chromium.org Review-Url: https://codereview.chromium.org/2872353003 Cr-Commit-Position: refs/heads/master@{#471547} Committed: https://chromium.googlesource.com/chromium/src/+/1c8889efcad513d89995f0c6eb2a3d6a0f3d4216

Patch Set 1 #

Patch Set 2 : deprecate histograms #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 2 3 chunks +6 lines, -21 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pauljensen
Helen, PTAL, thank you!
3 years, 7 months ago (2017-05-11 15:07:54 UTC) #1
xunjieli
On 2017/05/11 15:07:54, pauljensen wrote: > Helen, PTAL, thank you! lgtm. Could you mark these ...
3 years, 7 months ago (2017-05-11 15:14:16 UTC) #2
pauljensen
Steven, PTAL @ histograms.xml, thank you!
3 years, 7 months ago (2017-05-11 15:56:10 UTC) #4
pauljensen
Friendly ping Steven; this is a nice simple review, just marking some histograms deprecated.
3 years, 7 months ago (2017-05-12 11:46:56 UTC) #5
Steven Holte
On 2017/05/12 11:46:56, pauljensen wrote: > Friendly ping Steven; this is a nice simple review, ...
3 years, 7 months ago (2017-05-13 00:15:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872353003/40001
3 years, 7 months ago (2017-05-13 00:47:27 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 03:29:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c8889efcad513d89995f0c6eb2a...

Powered by Google App Engine
This is Rietveld 408576698