Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2872353002: [DMC #5.55v2] Add DocumentMarkerList::MarkerType() (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocumentMarkerList::MarkerType() We need a method on DocumentMarkerList that returns the marker type the list supports so we know when we can safely cast a DocumentMarkerList* to an impl type. This CL adds a MarkerType param to the constructor of SpellCheckMarkerListImpl so we can implement this method. Note that adding this method also requires modifying GenericDocumentMarkerListImpl to take a MarkerType param (we're going to eliminate GenericDocumentMarkerListImpl once we add TextMatchMarkerListImpl but we need this for now). BUG=707867

Patch Set 1 #

Powered by Google App Engine
This is Rietveld 408576698