Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 287233002: Start work on GN build for content/common (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam
Visibility:
Public.

Description

Start work on GN build for content/common Add a skeleton build file for content/common that lists the basic deps, and processes the sources. This can keep track of the deps that have been converted and allows easy testing of the .gypi reading. Changes content_common.gypi to separate out the public and private sources. The .gypi combines them both into the 'sources' so current users of this file should not be affected. This allows the GN build to declare the public API. Enhance the gypi-to-gn script to strip conditions and collapse variables to allow the content .gypis to be read in. Adds some simple BUILD.gn files for dependencies of content/common Fix typo in accessibility.gyp that I discovered when writing the GN build. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271767

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : make separate public target #

Patch Set 4 : #

Patch Set 5 : android fix #

Total comments: 2

Patch Set 6 : comment #

Patch Set 7 : comment fix #

Patch Set 8 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -436 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 3 chunks +6 lines, -2 lines 0 comments Download
M build/gypi_to_gn.py View 1 2 chunks +17 lines, -5 lines 0 comments Download
A + components/tracing/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
A content/common/BUILD.gn View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A content/common/common.gni View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 1 chunk +432 lines, -424 lines 0 comments Download
A content/public/common/BUILD.gn View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A ui/accessibility/BUILD.gn View 1 1 chunk +61 lines, -0 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 7 months ago (2014-05-17 02:30:38 UTC) #1
brettw
New snap up
6 years, 7 months ago (2014-05-19 16:57:40 UTC) #2
jam
https://codereview.chromium.org/287233002/diff/80001/content/common/common.gni File content/common/common.gni (right): https://codereview.chromium.org/287233002/diff/80001/content/common/common.gni#newcode7 content/common/common.gni:7: # the .gypi. with the caveat that i'm not ...
6 years, 7 months ago (2014-05-20 06:41:52 UTC) #3
brettw
New snap up https://codereview.chromium.org/287233002/diff/80001/content/common/common.gni File content/common/common.gni (right): https://codereview.chromium.org/287233002/diff/80001/content/common/common.gni#newcode7 content/common/common.gni:7: # the .gypi. Yes, I made ...
6 years, 7 months ago (2014-05-20 17:20:23 UTC) #4
jam
lgtm
6 years, 7 months ago (2014-05-20 19:52:51 UTC) #5
brettw
6 years, 7 months ago (2014-05-20 21:52:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #8 manually as r271767.

Powered by Google App Engine
This is Rietveld 408576698