content/common/common.gni - Issue 287233002: Start work on GN build for content/common

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/common.gni

Issue 287233002: Start work on GN build for content/common (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: android fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # This file defines the content common gypi values once so that the result can

	6 # be shared between the public and private GN builds without having to re-parse

	7 # the .gypi.
	jam 2014/05/20 06:41:52 with the caveat that i'm not familiar with gn, I s with the caveat that i'm not familiar with gn, I still am not sure exactly what the purpose of this file is? is it a performance optimization? brettw 2014/05/20 17:20:23 Yes, I made the comment more explicit about this. Yes, I made the comment more explicit about this.
	8 content_common_gypi_values = exec_script(

	9 "//build/gypi_to_gn.py",

	10 [ rebase_path("../content_common.gypi") ],

	11 "scope",

	12 [ "../content_common.gypi" ])

	13

OLD	NEW

« no previous file with comments | « content/common/BUILD.gn ('k') | content/content_common.gypi » ('j') | no next file with comments »