Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2872313002: Local NTP: Update the scope for the OneGoogle API (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Local NTP: Update the scope for the OneGoogle API BUG=583292 Review-Url: https://codereview.chromium.org/2872313002 Cr-Commit-Position: refs/heads/master@{#470594} Committed: https://chromium.googlesource.com/chromium/src/+/2b22fb640f88f055ab951a8fdc18bf073a2af90f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Marc Treib
I can haz rubberstamp plz?
3 years, 7 months ago (2017-05-10 13:47:05 UTC) #3
sfiera
LGTM only the rubberiest
3 years, 7 months ago (2017-05-10 13:59:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872313002/1
3 years, 7 months ago (2017-05-10 14:08:35 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:12:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b22fb640f88f055ab951a8fdc18...

Powered by Google App Engine
This is Rietveld 408576698