Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2872273004: Remove dead macros (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead macros BUG=675877, 720442 Review-Url: https://codereview.chromium.org/2872273004 Cr-Commit-Position: refs/heads/master@{#471100} Committed: https://chromium.googlesource.com/chromium/src/+/f4097d86ffef927e2d617a07e4bee2ad9ec31cbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M third_party/WebKit/Source/platform/wtf/PrintStream.h View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 36 (20 generated)
Nico
3 years, 7 months ago (2017-05-10 16:41:09 UTC) #3
dcheng
LGTM
3 years, 7 months ago (2017-05-10 16:48:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-10 16:52:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450418)
3 years, 7 months ago (2017-05-10 20:08:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-10 20:10:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450771)
3 years, 7 months ago (2017-05-10 22:12:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-11 13:27:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451780)
3 years, 7 months ago (2017-05-11 15:23:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-11 15:24:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451834)
3 years, 7 months ago (2017-05-11 16:53:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-11 16:57:23 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452042)
3 years, 7 months ago (2017-05-11 18:40:17 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-11 19:01:39 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452153)
3 years, 7 months ago (2017-05-11 21:01:21 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872273004/1
3 years, 7 months ago (2017-05-11 21:03:59 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:50:05 UTC) #36
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4097d86ffef927e2d617a07e4be...

Powered by Google App Engine
This is Rietveld 408576698