Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2872263002: [heap] Synchronize young generation GC with concurrent marking. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Synchronize young generation GC with concurrent marking. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2872263002 Cr-Commit-Position: refs/heads/master@{#45230} Committed: https://chromium.googlesource.com/v8/v8/+/61101232574569a69241f2d8835931db12a16eda

Patch Set 1 #

Patch Set 2 : add guard in Heap::EvacuateYoungGeneration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen-environment-liveness.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/concurrent-marking.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
ulan
ptal
3 years, 7 months ago (2017-05-10 11:34:05 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-10 11:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872263002/1
3 years, 7 months ago (2017-05-10 11:44:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40800)
3 years, 7 months ago (2017-05-10 11:49:08 UTC) #7
ulan
+jkummerow@ for crankshaft stamp.
3 years, 7 months ago (2017-05-10 12:07:04 UTC) #9
Jakob Kummerow
lgtm
3 years, 7 months ago (2017-05-10 12:43:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872263002/20001
3 years, 7 months ago (2017-05-10 12:48:59 UTC) #17
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 12:50:41 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/61101232574569a69241f2d8835931db12a...

Powered by Google App Engine
This is Rietveld 408576698