Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2872193004: Added some missing bucket labels to the CLD3 language detection conflict (Closed)

Created:
3 years, 7 months ago by martis
Modified:
3 years, 7 months ago
Reviewers:
napper, Sam McNally
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added some missing bucket labels to the CLD3 language detection conflict histogram. We have observed some conflicts for languages not currently in the label list (e.g. "zh-CN", "zh-TW", "jw"). This change gives these histogram buckets proper labels. BUG=704388 Review-Url: https://codereview.chromium.org/2872193004 Cr-Commit-Position: refs/heads/master@{#470783} Committed: https://chromium.googlesource.com/chromium/src/+/5f9e021b0ede1fde8ffb6593b25c9cba72b4d96c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M tools/metrics/histograms/enums.xml View 29 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
martis
+napper +isherman for histogram OWNERS Thanks!
3 years, 7 months ago (2017-05-10 23:16:31 UTC) #2
napper
lgtm
3 years, 7 months ago (2017-05-10 23:27:30 UTC) #3
Ilya Sherman
You don't need my review to add entries to enums.xml. Enjoy! =)
3 years, 7 months ago (2017-05-11 00:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872193004/1
3 years, 7 months ago (2017-05-11 00:54:44 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-11 00:54:46 UTC) #8
martis
+Sam for committer review
3 years, 7 months ago (2017-05-11 01:08:54 UTC) #11
Sam McNally
lgtm
3 years, 7 months ago (2017-05-11 01:11:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872193004/1
3 years, 7 months ago (2017-05-11 01:25:27 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 02:55:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f9e021b0ede1fde8ffb6593b25c...

Powered by Google App Engine
This is Rietveld 408576698