Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2872153002: Add public_deps for //components/toolbar:test_support and //components/search_engines (Closed)

Created:
3 years, 7 months ago by mattm
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add public_deps for //components/toolbar:test_support and //components/search_engines //components/toolbar details: test_toolbar_model.h includes toolbar_model.h, therefore :toolbar is part of :test_support public interface. Example error: In file included from ../../ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm:14: In file included from ../../components/toolbar/test_toolbar_model.h:13: In file included from ../../components/toolbar/toolbar_model.h:14: In file included from ../../components/security_state/core/security_state.h:16: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~ //components/search_engines details: template_url_service.h includes files from these targets (thus they are part of its public interface), but they weren't in public_deps. Example error: In file included from ../../ios/chrome/browser/physical_web/start_physical_web_discovery.mm:11: In file included from ../../components/search_engines/template_url_service.h:23: In file included from ../../components/google/core/browser/google_url_tracker.h:17: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~ BUG=none Review-Url: https://codereview.chromium.org/2872153002 Cr-Commit-Position: refs/heads/master@{#470692} Committed: https://chromium.googlesource.com/chromium/src/+/65c5401fe841ee0be6e904afac3fdd98d2460f3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M components/search_engines/BUILD.gn View 2 chunks +6 lines, -6 lines 0 comments Download
M components/toolbar/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mattm
3 years, 7 months ago (2017-05-10 01:33:16 UTC) #4
Peter Kasting
RS LGTM
3 years, 7 months ago (2017-05-10 20:17:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872153002/1
3 years, 7 months ago (2017-05-10 20:24:31 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 20:36:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65c5401fe841ee0be6e904afac3f...

Powered by Google App Engine
This is Rietveld 408576698