Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2872133009: ChromeOS: Fix DCHECK hit when logging under Guest (Closed)

Created:
3 years, 7 months ago by Alexander Alekseev
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Fix DCHECK hit when logging under Guest We should not SwitchToLastActiveUser() when there is only one user logged in. This covers restart on signin, when last_active_user may be outdated. BUG=714250 Review-Url: https://codereview.chromium.org/2872133009 Cr-Commit-Position: refs/heads/master@{#471127} Committed: https://chromium.googlesource.com/chromium/src/+/67cd35cee72cda91bc0f8254b1efc080e737d848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Alexander Alekseev
Please review.
3 years, 7 months ago (2017-05-11 20:09:13 UTC) #2
xiyuan
lgtm
3 years, 7 months ago (2017-05-11 20:15:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133009/1
3 years, 7 months ago (2017-05-11 23:35:56 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:56:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67cd35cee72cda91bc0f8254b1ef...

Powered by Google App Engine
This is Rietveld 408576698