Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2872133007: base: remove icu_util_nacl_win64.cc (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, danakj+watch_chromium.org, jshin+watch_chromium.org, vmpstr+watch_chromium.org, jungshik at Google
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

base: remove icu_util_nacl_win64.cc No .gn files reference this file anymore, and base_nacl_win64 target which used to reference it does not exist anymore as well. BUG=661774 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2872133007 Cr-Commit-Position: refs/heads/master@{#471173} Committed: https://chromium.googlesource.com/chromium/src/+/83d0a339b738a5d4a42673d8b763f4745b05a8f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
D base/i18n/icu_util_nacl_win64.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tfarina
3 years, 7 months ago (2017-05-10 23:01:09 UTC) #3
tfarina
Ping?
3 years, 7 months ago (2017-05-12 01:21:56 UTC) #6
Nico
lgtm Sorry, I missed this yesterday, thanks for the ping.
3 years, 7 months ago (2017-05-12 01:22:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133007/1
3 years, 7 months ago (2017-05-12 01:39:41 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:51:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83d0a339b738a5d4a42673d8b763...

Powered by Google App Engine
This is Rietveld 408576698