Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2872133006: Add full filename to sampled-download pings. (Closed)

Created:
3 years, 7 months ago by Nathan Parker
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add full filename to sampled-download pings. Also: Use NiceMock to cut test output from 380 to 160 lines BUG=720492 Review-Url: https://codereview.chromium.org/2872133006 Cr-Commit-Position: refs/heads/master@{#471845} Committed: https://chromium.googlesource.com/chromium/src/+/6f646a463c21b17b7967dcbb9f8046ebc11a06b0

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -49 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 30 chunks +41 lines, -41 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Nathan Parker
.
3 years, 7 months ago (2017-05-13 00:07:15 UTC) #6
Nathan Parker
3 years, 7 months ago (2017-05-13 00:13:40 UTC) #11
Jialiu Lin
lgtm
3 years, 7 months ago (2017-05-13 00:31:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133006/20001
3 years, 7 months ago (2017-05-15 17:43:14 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 18:41:15 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f646a463c21b17b7967dcbb9f80...

Powered by Google App Engine
This is Rietveld 408576698