Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2872133004: blink style: Update one class cluster, delete one class, change comment style. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink style: Update one class cluster, delete one class, change comment style. The C-style comments were confusing a regex. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2872133004 Cr-Commit-Position: refs/heads/master@{#471142} Committed: https://chromium.googlesource.com/chromium/src/+/459731e7f4376e99d785ac7b0d40622747ca318e

Patch Set 1 #

Total comments: 2

Patch Set 2 : fun #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -86 lines) Patch
M third_party/WebKit/Source/platform/heap/WrapperVisitor.h View 1 2 chunks +32 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LineEnding.cpp View 5 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
Nico
3 years, 7 months ago (2017-05-10 17:33:51 UTC) #3
dcheng
LGTM https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right): https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h#newcode53 third_party/WebKit/Source/platform/heap/WrapperVisitor.h:53: // visitor->traceWrappers(node_lists_); Just to confirm: the comment CLs ...
3 years, 7 months ago (2017-05-10 17:37:06 UTC) #5
Nico
https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right): https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/platform/heap/WrapperVisitor.h#newcode53 third_party/WebKit/Source/platform/heap/WrapperVisitor.h:53: // visitor->traceWrappers(node_lists_); On 2017/05/10 17:37:06, dcheng wrote: > Just ...
3 years, 7 months ago (2017-05-10 17:42:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133004/20001
3 years, 7 months ago (2017-05-10 17:43:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450568)
3 years, 7 months ago (2017-05-10 20:25:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133004/20001
3 years, 7 months ago (2017-05-11 13:28:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451800)
3 years, 7 months ago (2017-05-11 16:08:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133004/20001
3 years, 7 months ago (2017-05-11 16:09:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451892)
3 years, 7 months ago (2017-05-11 17:51:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133004/20001
3 years, 7 months ago (2017-05-11 17:58:47 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452057)
3 years, 7 months ago (2017-05-11 20:15:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872133004/20001
3 years, 7 months ago (2017-05-11 20:39:43 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 00:29:59 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/459731e7f4376e99d785ac7b0d40...

Powered by Google App Engine
This is Rietveld 408576698