|
|
Descriptionblink style: Update one class cluster, delete one class, change comment style.
The C-style comments were confusing a regex.
No behavior change.
BUG=675877
Review-Url: https://codereview.chromium.org/2872133004
Cr-Commit-Position: refs/heads/master@{#471142}
Committed: https://chromium.googlesource.com/chromium/src/+/459731e7f4376e99d785ac7b0d40622747ca318e
Patch Set 1 #
Total comments: 2
Patch Set 2 : fun #
Messages
Total messages: 28 (15 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + dcheng@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right): https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/heap/WrapperVisitor.h:53: // visitor->traceWrappers(node_lists_); Just to confirm: the comment CLs are mostly scoped at fixing m_foo and not so much at functionCall(), right?
https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/p... File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right): https://codereview.chromium.org/2872133004/diff/1/third_party/WebKit/Source/p... third_party/WebKit/Source/platform/heap/WrapperVisitor.h:53: // visitor->traceWrappers(node_lists_); On 2017/05/10 17:37:06, dcheng wrote: > Just to confirm: the comment CLs are mostly scoped at fixing m_foo and not so > much at functionCall(), right? Yes, but done too, thanks. (I'm only focusing on things not-in-comments too, but the c-style comment here defeated my cs query.)
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2872133004/#ps20001 (title: "fun")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494535070853720, "parent_rev": "84869d699fe82560ca9ac3f30c5b959110af30bf", "commit_rev": "459731e7f4376e99d785ac7b0d40622747ca318e"}
Message was sent while issue was closed.
Description was changed from ========== blink style: Update one class cluster, delete one class, change comment style. The C-style comments were confusing a regex. No behavior change. BUG=675877 ========== to ========== blink style: Update one class cluster, delete one class, change comment style. The C-style comments were confusing a regex. No behavior change. BUG=675877 Review-Url: https://codereview.chromium.org/2872133004 Cr-Commit-Position: refs/heads/master@{#471142} Committed: https://chromium.googlesource.com/chromium/src/+/459731e7f4376e99d785ac7b0d40... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/459731e7f4376e99d785ac7b0d40... |