Wallpaper resize extents compositor lock timeout.

Wallpaper resize extents compositor lock timeout.

Sometime wallpaper has not been resized when screen rotation animating.
Users can see a wallpaper resize after rotates the screen. The solution
is that to acquire compositor lock when resizing wallpaper so that to
prevent Screen Rotation Animator animating.

BUG=678763
Test=tested locally that wallpaper was resized before screen rotation
animation.

Review-Url: https://codereview.chromium.org/2872123002
Cr-Commit-Position: refs/heads/master@{#470735}
Committed: https://chromium.googlesource.com/chromium/src/+/eb552059c7c48312cd176433b370481e211e8987

[wutao, 2017-05-10 01:05:48]

wutao@chromium.org changed reviewers:
+ oshima@chromium.org

[wutao, 2017-05-10 01:05:49]

Hi Oshima,

Could you please have a look.

Thanks,
Tao

[wutao, 2017-05-10 01:06:13]

The CQ bit was checked by wutao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:07:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:10:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[oshima, 2017-05-10 05:27:50]

can you look into bot failures?

https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animator.cc (right):

https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animator.cc:240:
compositor->set_allow_locks_to_extend_timeout(false);
move this to 235, after SetDisplayRotation

[wutao, 2017-05-10 05:45:18]

On 2017/05/10 05:27:50, oshima wrote:
> can you look into bot failures?
> 
>
https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
> File ash/rotator/screen_rotation_animator.cc (right):
> 
>
https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
> ash/rotator/screen_rotation_animator.cc:240:
> compositor->set_allow_locks_to_extend_timeout(false);
> move this to 235, after SetDisplayRotation

Will move to line 235.
I have not push the compositor lock change yet, so the bot error is: no member
named 'set_allow_locks_to_extend_timeout' in 'ui::Compositor'

[oshima, 2017-05-10 20:44:22]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 20:45:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wutao, 2017-05-10 21:07:55]

Hi Oshima,

ptal.

Thanks.
Tao

https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animator.cc (right):

https://codereview.chromium.org/2872123002/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animator.cc:240:
compositor->set_allow_locks_to_extend_timeout(false);
On 2017/05/10 05:27:50, oshima wrote:
> move this to 235, after SetDisplayRotation

Done.

[wutao, 2017-05-10 21:08:02]

The CQ bit was checked by wutao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 21:09:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-05-10 21:17:18]

lgtm

[commit-bot: I haz the power, 2017-05-10 22:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:16:07]

Dry run: This issue passed the CQ dry run.

[wutao, 2017-05-10 22:23:56]

The CQ bit was checked by wutao@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:24:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:35:33]

CQ is committing da patch.

Bot data: {"patchset_id": 10004, "attempt_start_ts": 1494455036999700,
"parent_rev": "efc4ecaaace1ccf817ebbc1517c7290b1f0a3dd3", "commit_rev":
"eb552059c7c48312cd176433b370481e211e8987"}

[commit-bot: I haz the power, 2017-05-10 22:35:45]

Description was changed from

==========
Wallpaper resize extents compositor lock timeout.

Sometime wallpaper has not been resized when screen rotation animating.
Users can see a wallpaper resize after rotates the screen. The solution
is that to acquire compositor lock when resizing wallpaper so that to
prevent Screen Rotation Animator animating.

BUG=678763
Test=tested locally that wallpaper was resized before screen rotation
animation.
==========

to

==========
Wallpaper resize extents compositor lock timeout.

Sometime wallpaper has not been resized when screen rotation animating.
Users can see a wallpaper resize after rotates the screen. The solution
is that to acquire compositor lock when resizing wallpaper so that to
prevent Screen Rotation Animator animating.

BUG=678763
Test=tested locally that wallpaper was resized before screen rotation
animation.

Review-Url: https://codereview.chromium.org/2872123002
Cr-Commit-Position: refs/heads/master@{#470735}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb552059c7c48312cd176433b370...
==========

[commit-bot: I haz the power, 2017-05-10 22:35:45]

Committed patchset #3 (id:10004) as
https://chromium.googlesource.com/chromium/src/+/eb552059c7c48312cd176433b370...