Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2872113002: Add parsing code for RFC 5280 PolicyConstraints. (Closed)

Created:
3 years, 7 months ago by eroman
Modified:
3 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add parsing code for RFC 5280 PolicyConstraints. BUG=634452 Review-Url: https://codereview.chromium.org/2872113002 Cr-Commit-Position: refs/heads/master@{#471572} Committed: https://chromium.googlesource.com/chromium/src/+/25ead1bcf8bae5dc3f1876d63fe81b3bfd3a9190

Patch Set 1 #

Total comments: 2

Patch Set 2 : address mattm's comment (move to certificate_policies) #

Patch Set 3 : update ios bundle_data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -0 lines) Patch
M net/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/cert/internal/certificate_policies.h View 1 2 chunks +17 lines, -0 lines 0 comments Download
M net/cert/internal/certificate_policies.cc View 1 2 chunks +65 lines, -0 lines 0 comments Download
M net/cert/internal/certificate_policies_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/cert/internal/parse_certificate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/internal/parsed_certificate.h View 1 3 chunks +15 lines, -0 lines 0 comments Download
M net/cert/internal/parsed_certificate.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/cert/internal/parsed_certificate_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/policy_constraints_empty.pem View 1 chunk +15 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/policy_constraints_inhibit.pem View 1 chunk +16 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/policy_constraints_inhibit_require.pem View 1 chunk +17 lines, -0 lines 0 comments Download
A net/data/parse_certificate_unittest/policy_constraints_require.pem View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
eroman
3 years, 7 months ago (2017-05-10 00:57:21 UTC) #2
mattm
lgtm w/suggestion https://codereview.chromium.org/2872113002/diff/1/net/cert/internal/parse_certificate.h File net/cert/internal/parse_certificate.h (right): https://codereview.chromium.org/2872113002/diff/1/net/cert/internal/parse_certificate.h#newcode460 net/cert/internal/parse_certificate.h:460: struct ParsedPolicyConstraints { we don't really have ...
3 years, 7 months ago (2017-05-10 20:01:23 UTC) #3
eroman
https://codereview.chromium.org/2872113002/diff/1/net/cert/internal/parse_certificate.h File net/cert/internal/parse_certificate.h (right): https://codereview.chromium.org/2872113002/diff/1/net/cert/internal/parse_certificate.h#newcode460 net/cert/internal/parse_certificate.h:460: struct ParsedPolicyConstraints { On 2017/05/10 20:01:23, mattm wrote: > ...
3 years, 7 months ago (2017-05-13 01:10:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872113002/40001
3 years, 7 months ago (2017-05-13 06:31:41 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 06:45:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/25ead1bcf8bae5dc3f1876d63fe8...

Powered by Google App Engine
This is Rietveld 408576698