Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2872083002: Add a WideStringToString() helper function to PDFiumEngine. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
dsinclair
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a WideStringToString() helper function to PDFiumEngine. Fix various nits as well. Review-Url: https://codereview.chromium.org/2872083002 Cr-Commit-Position: refs/heads/master@{#470590} Committed: https://chromium.googlesource.com/chromium/src/+/d670d189b692d1d7c80471054155b5b2ed968a69

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -67 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 13 chunks +39 lines, -67 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
3 years, 7 months ago (2017-05-10 00:43:48 UTC) #2
dsinclair
lgtm
3 years, 7 months ago (2017-05-10 14:24:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872083002/20001
3 years, 7 months ago (2017-05-10 14:25:15 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:04:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d670d189b692d1d7c80471054155...

Powered by Google App Engine
This is Rietveld 408576698