[heap] Bound number of tasks by embedder limit instead of artificially capping

[heap] Bound number of tasks by embedder limit instead of artificially capping

BUG=chromium:651354
Review-Url: https://codereview.chromium.org/2872063003
Cr-Commit-Position: refs/heads/master@{#45235}
Committed: https://chromium.googlesource.com/v8/v8/+/f86985ad116d75255ddf78b3a4df2590543fd8cd

[Michael Lippautz, 2017-05-10 14:38:39]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2017-05-10 14:38:40]

https://codereview.chromium.org/2872063003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/2872063003/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:350:
heap()->tracer()->CompactionSpeedInBytesPerMillisecond();
I will get rid of this one if we decide to keep it that simple.

[Hannes Payer (out of office), 2017-05-10 14:40:32]

lgtm

[Michael Lippautz, 2017-05-10 14:51:28]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 14:51:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:26:13]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2017-05-10 15:28:30]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-05-10 15:28:30]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2872063003/#ps20001
(title: "Fix compilation")

[commit-bot: I haz the power, 2017-05-10 15:28:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 15:30:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494430110163890,
"parent_rev": "11a211ff1b81e8d83d1aa4898743c2efb89603bd", "commit_rev":
"f86985ad116d75255ddf78b3a4df2590543fd8cd"}

[commit-bot: I haz the power, 2017-05-10 15:30:45]

Description was changed from

==========
[heap] Bound number of tasks by embedder limit instead of artificially capping

BUG=chromium:651354
==========

to

==========
[heap] Bound number of tasks by embedder limit instead of artificially capping

BUG=chromium:651354

Review-Url: https://codereview.chromium.org/2872063003
Cr-Commit-Position: refs/heads/master@{#45235}
Committed:
https://chromium.googlesource.com/v8/v8/+/f86985ad116d75255ddf78b3a4df2590543...
==========

[commit-bot: I haz the power, 2017-05-10 15:30:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f86985ad116d75255ddf78b3a4df2590543...

[Michael Achenbach, 2017-05-11 05:19:57]

The breaks
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
PTAL

[Michael Lippautz, 2017-05-11 06:00:10]

On 2017/05/11 05:19:57, Michael Achenbach wrote:
> The breaks
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> PTAL

I will have a look and will revert if I don't find anything. Looks like using
more tasks in the GC is flushing something out here.

[Michael Lippautz, 2017-05-11 06:48:04]

On 2017/05/11 06:00:10, Michael Lippautz wrote:
> On 2017/05/11 05:19:57, Michael Achenbach wrote:
> > The breaks
> >
>
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...
> > PTAL
> 
> I will have a look and will revert if I don't find anything. Looks like using
> more tasks in the GC is flushing something out here.

Maybe
https://chromium.googlesource.com/v8/v8/+/11a211ff1b81e8d83d1aa4898743c2efb89...
? This is also in the range.

[Michael Achenbach, 2017-05-11 09:12:50]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-05-11 09:12:50]

auto-bisect reproed with this CL...

[Michael Lippautz, 2017-05-11 09:13:56]

https://bugs.chromium.org/p/v8/issues/detail?id=6389

Flushing out an issue somewhere else.