Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2872053002: Linux native notifications: Support image notifications (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux native notifications: Support image notifications BUG=676220 R=peter@chromium.org Review-Url: https://codereview.chromium.org/2872053002 Cr-Commit-Position: refs/heads/master@{#471993} Committed: https://chromium.googlesource.com/chromium/src/+/42ebc4fd9b073bbcb4a2845aa5862c8fcab2a8a0

Patch Set 1 #

Total comments: 8

Patch Set 2 : Resize on task runner #

Total comments: 7

Patch Set 3 : address thestig@'s comments #

Patch Set 4 : Rebase #

Total comments: 10

Patch Set 5 : Rebase #

Patch Set 6 : Add unit test #

Total comments: 8

Patch Set 7 : cleanups #

Patch Set 8 : base::Optional<bool> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -12 lines) Patch
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 1 2 3 4 5 6 7 10 chunks +73 lines, -11 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc View 1 2 3 4 5 6 7 7 chunks +62 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (13 generated)
Peter Beverloo
https://codereview.chromium.org/2872053002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode50 chrome/browser/notifications/notification_platform_bridge_linux.cc:50: const int kMaxImageHeight = 100; This is tiny! Developers ...
3 years, 7 months ago (2017-05-10 12:54:40 UTC) #1
Tom (Use chromium acct)
+thestig https://codereview.chromium.org/2872053002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/1/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode50 chrome/browser/notifications/notification_platform_bridge_linux.cc:50: const int kMaxImageHeight = 100; On 2017/05/10 12:54:40, ...
3 years, 7 months ago (2017-05-11 00:07:04 UTC) #3
Lei Zhang
https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode66 chrome/browser/notifications/notification_platform_bridge_linux.cc:66: int ClampInt(int v, int lo, int hi) { return ...
3 years, 7 months ago (2017-05-11 00:54:57 UTC) #4
Lei Zhang
https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode461 chrome/browser/notifications/notification_platform_bridge_linux.cc:461: void DisplayOnTaskRunner(NotificationCommon::Type notification_type, BTW, this is now ~150 lines ...
3 years, 7 months ago (2017-05-11 01:00:01 UTC) #5
Tom (Use chromium acct)
https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/20001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode66 chrome/browser/notifications/notification_platform_bridge_linux.cc:66: int ClampInt(int v, int lo, int hi) { On ...
3 years, 7 months ago (2017-05-11 01:28:23 UTC) #6
Tom (Use chromium acct)
ping
3 years, 7 months ago (2017-05-12 20:04:38 UTC) #11
Peter Beverloo
https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode548 chrome/browser/notifications/notification_platform_bridge_linux.cc:548: "<img src=\"" + image_file->file_path().value() + "\" alt=\"\"/>"; Let's use ...
3 years, 7 months ago (2017-05-15 16:16:00 UTC) #12
Tom (Use chromium acct)
https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode548 chrome/browser/notifications/notification_platform_bridge_linux.cc:548: "<img src=\"" + image_file->file_path().value() + "\" alt=\"\"/>"; On 2017/05/15 ...
3 years, 7 months ago (2017-05-15 19:18:39 UTC) #13
Lei Zhang
https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode843 chrome/browser/notifications/notification_platform_bridge_linux.cc:843: bool body_images_supported_ = true; On 2017/05/15 19:18:39, Tom Anderson ...
3 years, 7 months ago (2017-05-15 21:48:41 UTC) #14
Peter Beverloo
lgtm w/ suggestion https://codereview.chromium.org/2872053002/diff/100001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/100001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode554 chrome/browser/notifications/notification_platform_bridge_linux.cc:554: body << "<b>" << title << ...
3 years, 7 months ago (2017-05-15 22:07:33 UTC) #15
Lei Zhang
https://codereview.chromium.org/2872053002/diff/100001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/100001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode566 chrome/browser/notifications/notification_platform_bridge_linux.cc:566: body << "<img src=\"" << image_file->file_path().value() BTW, we should ...
3 years, 7 months ago (2017-05-15 22:13:12 UTC) #16
Tom (Use chromium acct)
https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc File chrome/browser/notifications/notification_platform_bridge_linux.cc (right): https://codereview.chromium.org/2872053002/diff/60001/chrome/browser/notifications/notification_platform_bridge_linux.cc#newcode843 chrome/browser/notifications/notification_platform_bridge_linux.cc:843: bool body_images_supported_ = true; On 2017/05/15 21:48:40, Lei Zhang ...
3 years, 7 months ago (2017-05-16 00:22:01 UTC) #17
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-16 00:42:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872053002/140001
3 years, 7 months ago (2017-05-16 02:51:17 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 02:56:30 UTC) #28
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/42ebc4fd9b073bbcb4a2845aa586...

Powered by Google App Engine
This is Rietveld 408576698