Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2872033003: Add some missing public_deps for //components/sync (Closed)

Created:
3 years, 7 months ago by mattm
Modified:
3 years, 7 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing public_deps for //components/sync sync_stopped_reporter.h includes files from these targets, therefore they are part of its public interface. Example error: In file included from ../../ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm:10: In file included from ../../components/browser_sync/profile_sync_service.h:43: In file included from ../../components/sync/driver/sync_stopped_reporter.h:14: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: In file included from ../../net/cert/x509_certificate.h:25: ../../third_party/boringssl/src/include/openssl/base.h:71:10: fatal error: 'openssl/is_boringssl.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~ BUG=none Review-Url: https://codereview.chromium.org/2872033003 Cr-Commit-Position: refs/heads/master@{#470500} Committed: https://chromium.googlesource.com/chromium/src/+/7b22c73b32037861ca20e3689176108b88690853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/sync/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mattm
3 years, 7 months ago (2017-05-10 01:34:56 UTC) #4
maxbogue
lgtm
3 years, 7 months ago (2017-05-10 02:38:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033003/1
3 years, 7 months ago (2017-05-10 06:14:37 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 06:19:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b22c73b32037861ca20e3689176...

Powered by Google App Engine
This is Rietveld 408576698