Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2872033002: Pass isPrinting and other bits from parent context to child during print. (Closed)

Created:
3 years, 7 months ago by chrishtr
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass isPrinting and other bits from parent context to child during print. BUG=718362 Review-Url: https://codereview.chromium.org/2872033002 Cr-Commit-Position: refs/heads/master@{#471204} Committed: https://chromium.googlesource.com/chromium/src/+/fb001947e4c1149351519bdfa30858843978f048

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : Merge branch 'master' into fixprinting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/paint/printing/print-box-shadow.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/printing/print-box-shadow-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/paint/printing/print-box-shadow-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 30 (16 generated)
chrishtr
3 years, 7 months ago (2017-05-09 23:19:50 UTC) #3
pdr.
On 2017/05/09 at 23:19:50, chrishtr wrote: > LGTM
3 years, 7 months ago (2017-05-09 23:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/20001
3 years, 7 months ago (2017-05-09 23:31:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/265252)
3 years, 7 months ago (2017-05-10 00:18:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/20001
3 years, 7 months ago (2017-05-10 16:31:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450377)
3 years, 7 months ago (2017-05-10 18:35:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/20001
3 years, 7 months ago (2017-05-11 00:07:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451050)
3 years, 7 months ago (2017-05-11 01:39:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/40001
3 years, 7 months ago (2017-05-11 14:56:17 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451875)
3 years, 7 months ago (2017-05-11 16:46:01 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/40001
3 years, 7 months ago (2017-05-11 16:59:07 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/452054)
3 years, 7 months ago (2017-05-11 18:58:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872033002/40001
3 years, 7 months ago (2017-05-12 02:26:50 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 03:16:08 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb001947e4c1149351519bdfa308...

Powered by Google App Engine
This is Rietveld 408576698