Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2871963002: Update android studio doc about formatting commits. (Closed)

Created:
3 years, 7 months ago by F
Modified:
3 years, 7 months ago
Reviewers:
estevenson, Peter Wen
CC:
chromium-reviews, nyquist+watch_chromium.org, wnwen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update android studio doc about formatting commits. Review-Url: https://codereview.chromium.org/2871963002 Cr-Commit-Position: refs/heads/master@{#470591} Committed: https://chromium.googlesource.com/chromium/src/+/38bf00de6514fea4fea3d26f89ff62ad194c2334

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update android studio doc about formatting commits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M docs/android_studio.md View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
F
Hi Eric, PTAL. Thanks!
3 years, 7 months ago (2017-05-09 15:30:31 UTC) #2
estevenson
lgtm https://codereview.chromium.org/2871963002/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2871963002/diff/1/docs/android_studio.md#newcode106 docs/android_studio.md:106: * Help -> Find Action -> "Version Control" ...
3 years, 7 months ago (2017-05-09 15:50:52 UTC) #3
F
Thanks Eric! PTAL https://codereview.chromium.org/2871963002/diff/1/docs/android_studio.md File docs/android_studio.md (right): https://codereview.chromium.org/2871963002/diff/1/docs/android_studio.md#newcode106 docs/android_studio.md:106: * Help -> Find Action -> ...
3 years, 7 months ago (2017-05-09 17:29:28 UTC) #4
estevenson
On 2017/05/09 17:29:28, F wrote: > Thanks Eric! PTAL > > https://codereview.chromium.org/2871963002/diff/1/docs/android_studio.md > File docs/android_studio.md ...
3 years, 7 months ago (2017-05-09 17:36:00 UTC) #5
Peter Wen
This is really good, thanks Felix! lgtm
3 years, 7 months ago (2017-05-10 15:46:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871963002/20001
3 years, 7 months ago (2017-05-10 15:50:17 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:05:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38bf00de6514fea4fea3d26f89ff...

Powered by Google App Engine
This is Rietveld 408576698