Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2871933002: bindings: Fix coding style in SequenceTest. (Closed)

Created:
3 years, 7 months ago by Raphael Kubo da Costa (rakuco)
Modified:
3 years, 7 months ago
Reviewers:
haraken, Nico, bashi, Yuki
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Fix coding style in SequenceTest. This code was originally written before the recent Blink rename commit, and |m_elementSequence|'s name was not adjusted accordingly when the CL finally landed. Rename it to |element_sequence_|. R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2871933002 Cr-Commit-Position: refs/heads/master@{#470424} Committed: https://chromium.googlesource.com/chromium/src/+/95e56bea3ec8c9cb607e3fb28f93ed3edad8b755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/testing/SequenceTest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/SequenceTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Raphael Kubo da Costa (rakuco)
PTAL
3 years, 7 months ago (2017-05-09 14:48:01 UTC) #1
haraken
LGTM
3 years, 7 months ago (2017-05-09 15:19:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871933002/1
3 years, 7 months ago (2017-05-09 19:56:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/95e56bea3ec8c9cb607e3fb28f93ed3edad8b755
3 years, 7 months ago (2017-05-09 22:06:37 UTC) #11
Yuki
3 years, 7 months ago (2017-05-10 06:38:48 UTC) #12
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698