Remove overrides of HitTestRect() which just return false

Remove overrides of HitTestRect() which just return false

Some overrides of View::HitTestRect() just return 
false in order to force event-targeting to fail for
that view type and its descendants. Because this 
logic is unrelated to hit-testing against a rectangular
region, remove these overrides and instead override 
View::CanProcessEventsWithinSubtree() to just return 
false.

The relevant classes are:

ProfileImageView
ShelfButton::BarView
ShelfButton::IconView
PasswordRow
BoundedLabel
Label (and Link as a result)

BUG=374303
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274366

[tdanderson, 2014-05-16 18:17:50]

Sadrul, PTAL.

[sadrul, 2014-05-20 17:26:31]

This looks great! But do we respect CanAcceptEvent() for mouse/gesture events on
a View?

[tdanderson, 2014-05-20 18:48:52]

On 2014/05/20 17:26:31, sadrul wrote:
> This looks great! But do we respect CanAcceptEvent() for mouse/gesture events
on
> a View?

I believe this will "just work" because of the early check for 
CanAcceptEvent() in EventDispatcher::ProcessEvent(). If this is
false, the event is not dispatched and remains unhandled, which
means that it will bubble up the view hierarchy.

[sadrul, 2014-05-21 15:42:10]

lgtm

[sadrul, 2014-05-21 15:44:58]

https://codereview.chromium.org/287193002/diff/1/ui/views/controls/link.cc
File ui/views/controls/link.cc (right):

https://codereview.chromium.org/287193002/diff/1/ui/views/controls/link.cc#ne...
ui/views/controls/link.cc:172: return true;
I think this should return View::CanAcceptEvent(event);

[tdanderson, 2014-05-21 21:03:26]

Comments addressed. Sadrul, please take another look.

https://codereview.chromium.org/287193002/diff/1/ui/views/controls/link.cc
File ui/views/controls/link.cc (right):

https://codereview.chromium.org/287193002/diff/1/ui/views/controls/link.cc#ne...
ui/views/controls/link.cc:172: return true;
On 2014/05/21 15:44:59, sadrul wrote:
> I think this should return View::CanAcceptEvent(event);

Done.

[sadrul, 2014-05-21 21:54:21]

lgtm

[tdanderson, 2014-05-21 22:22:53]

Scott, can you please take a look at the changes in:

ash/
chrome/
ui/message_center/ ?

[sky, 2014-05-21 23:03:58]

https://codereview.chromium.org/287193002/diff/40001/ash/shelf/shelf_button.cc
File ash/shelf/shelf_button.cc (left):

https://codereview.chromium.org/287193002/diff/40001/ash/shelf/shelf_button.c...
ash/shelf/shelf_button.cc:205: // Return false so that ShelfButton gets all the
mouse events.
Please keep these comments, they are helpful.

https://codereview.chromium.org/287193002/diff/40001/ui/message_center/views/...
File ui/message_center/views/bounded_label.h (left):

https://codereview.chromium.org/287193002/diff/40001/ui/message_center/views/...
ui/message_center/views/bounded_label.h:58: virtual bool HitTestRect(const
gfx::Rect& rect) const OVERRIDE;
Shouldn't you override CanAcceptEvents here?

[tdanderson, 2014-05-22 19:14:19]

Scott, can you please take another look?

https://codereview.chromium.org/287193002/diff/40001/ash/shelf/shelf_button.cc
File ash/shelf/shelf_button.cc (left):

https://codereview.chromium.org/287193002/diff/40001/ash/shelf/shelf_button.c...
ash/shelf/shelf_button.cc:205: // Return false so that ShelfButton gets all the
mouse events.
On 2014/05/21 23:03:58, sky wrote:
> Please keep these comments, they are helpful.

Done.

https://codereview.chromium.org/287193002/diff/40001/ui/message_center/views/...
File ui/message_center/views/bounded_label.h (left):

https://codereview.chromium.org/287193002/diff/40001/ui/message_center/views/...
ui/message_center/views/bounded_label.h:58: virtual bool HitTestRect(const
gfx::Rect& rect) const OVERRIDE;
On 2014/05/21 23:03:58, sky wrote:
> Shouldn't you override CanAcceptEvents here?

Done.

[sky, 2014-05-22 19:53:52]

LGTM

[tdanderson, 2014-05-22 19:54:29]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-05-22 19:58:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/287193002/60001

[tdanderson, 2014-05-22 21:06:44]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2014-05-22 21:24:09]

On 2014/05/22 21:06:44, tdanderson wrote:
> The CQ bit was unchecked by mailto:tdanderson@chromium.org

Took this out of the CQ until I more thoroughly investigate
the reverts of r272133 and r272117.

[tdanderson, 2014-06-02 19:27:36]

Scott and Sadrul, can you please take a look at my new approach here?

[sadrul, 2014-06-02 20:57:16]

lgtm

[sky, 2014-06-02 21:37:57]

LGTM

[tdanderson, 2014-06-02 22:51:13]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2014-06-02 22:51:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdanderson@chromium.org/287193002/80001

[commit-bot: I haz the power, 2014-06-02 23:22:55]

Change committed as 274366