Remove overrides of HitTestRect() which just return false

ui/views/controls/link.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/link.h"
 
 #include "build/build_config.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 33 matching lines @@
 const char* Link::GetClassName() const {
   return kViewClassName;
 }
 
 gfx::NativeCursor Link::GetCursor(const ui::MouseEvent& event) {
   if (!enabled())
     return gfx::kNullCursor;
   return GetNativeHandCursor();
 }
 
-bool Link::HitTestRect(const gfx::Rect& rect) const {
-  // We need to allow clicks on the link. So we override the implementation in
-  // Label and use the default implementation of View.
-  return View::HitTestRect(rect);
-}
-
 bool Link::OnMousePressed(const ui::MouseEvent& event) {
   if (!enabled() ||
       (!event.IsLeftMouseButton() && !event.IsMiddleMouseButton()))
     return false;
   SetPressed(true);
   return true;
 }
 
 bool Link::OnMouseDragged(const ui::MouseEvent& event) {
   SetPressed(enabled() &&
@@ skipping 95 matching lines @@
   // border, when in this case we probably wanted zero width.
   SetFocusable(!text.empty());
 }
 
 void Link::SetEnabledColor(SkColor color) {
   requested_enabled_color_ = color;
   if (!pressed_)
     Label::SetEnabledColor(requested_enabled_color_);
 }
 
+bool Link::CanAcceptEvent(const ui::Event& event) {
+  // Links need to be able to accept events (e.g., clicking) even though
+  // in general Labels do not.
+  return true;

[sadrul, 2014/05/21 15:44:59]

I think this should return View::CanAcceptEvent(event);

[tdanderson, 2014/05/21 21:03:26]

Done.

+}
+
 void Link::SetPressedColor(SkColor color) {
   requested_pressed_color_ = color;
   if (pressed_)
     Label::SetEnabledColor(requested_pressed_color_);
 }
 
 void Link::SetUnderline(bool underline) {
   if (underline_ == underline)
     return;
   underline_ = underline;
@@ skipping 35 matching lines @@
 void Link::RecalculateFont() {
   // Underline the link iff it is enabled and |underline_| is true.
   const int style = font_list().GetFontStyle();
   const int intended_style = (enabled() && underline_) ?
       (style | gfx::Font::UNDERLINE) : (style & ~gfx::Font::UNDERLINE);
   if (style != intended_style)
     Label::SetFontList(font_list().DeriveWithStyle(intended_style));
 }
 
 }  // namespace views