color: Ensure solid color IOSurface layers are sRGB

ui/gfx/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//device/vr/features/features.gni")
 import("//testing/test.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 
 if (is_android) {
@@ skipping 145 matching lines @@
     "scrollbar_size.cc",
     "scrollbar_size.h",
     "selection_model.cc",
     "selection_model.h",
     "sequential_id_generator.cc",
     "sequential_id_generator.h",
     "shadow_value.cc",
     "shadow_value.h",
     "skbitmap_operations.cc",
     "skbitmap_operations.h",
-    "switches.cc",
-    "switches.h",
     "sys_color_change_listener.cc",
     "sys_color_change_listener.h",
     "text_constants.h",
     "text_elider.cc",
     "text_elider.h",
     "text_utils.cc",
     "text_utils.h",
     "text_utils_android.cc",
     "text_utils_ios.mm",
     "ui_gfx_exports.cc",
@@ skipping 56 matching lines @@
 
   # This is part of the gfx component in the component build.
   defines = [ "GFX_IMPLEMENTATION" ]
 
   public_deps = [
     ":color_space",
     ":geometry_skia",
     ":memory_buffer_sources",
     ":native_widget_types",
     ":selection_bound_sources",
+    ":switches_sources",
     "//base",
     "//skia",
     "//third_party/icu",
     "//ui/gfx/animation",
     "//ui/gfx/codec",
     "//ui/gfx/geometry",
     "//ui/gfx/range",
   ]
   deps = [
     ":gfx_export",
@@ skipping 268 matching lines @@
       "gpu_memory_buffer.h",
       "gpu_memory_buffer_tracing.cc",
       "gpu_memory_buffer_tracing.h",
     ]
   }
 
   defines = [ "GFX_IMPLEMENTATION" ]
 
   deps = [
     ":native_widget_types",
+    ":switches_sources",
     "//base",
     "//ui/gfx/geometry",
   ]
 
   if (is_linux) {
     sources += [
       "linux/client_native_pixmap_dmabuf.cc",
       "linux/client_native_pixmap_dmabuf.h",
       "linux/client_native_pixmap_factory_dmabuf.cc",
       "linux/client_native_pixmap_factory_dmabuf.h",
     ]
 
     deps += [ "//third_party/libdrm" ]
   }
 }
 
+source_set("switches_sources") {
+  visibility = [ ":*" ]  # Depend on through ":switches_sources".
+
+  sources = [
+    "switches.cc",
+    "switches.h",

[Nico, 2017/05/09 21:41:11]

These aren't generated or anything -- is the motivation to effectively do

  public = [ "switches.h" ]

over in gfx? (see `gn help public`)

(and possibly for a few more headers)

[ccameron, 2017/05/10 10:19:31]

I don't think so.

The motivation was because
- I need to access switches.h in mac/io_surface.cc, which is part of
memory_buffer_sources
- gfx depends on memory_buffer_sources.
- switches.h is in gfx

So, trying to include switches.h results in the circular dependency
memory_buffer_sources (mac/io_surface.cc) -> gfx (switches.h) ->
memory_buffer_sources

So, to break the dependency, I took switches.h and moved it to its own target.

+  ]
+
+  defines = [ "GFX_IMPLEMENTATION" ]
+
+  deps = [
+    ":gfx_export",
+    "//base",
+  ]
+}
+
 static_library("test_support") {
   testonly = true
   sources = [
     "animation/test_animation_delegate.h",
     "geometry/test/rect_test_util.cc",
     "geometry/test/rect_test_util.h",
     "image/image_unittest_util.cc",
     "image/image_unittest_util.h",
     "image/image_unittest_util_ios.mm",
     "image/image_unittest_util_mac.mm",
@@ skipping 209 matching lines @@
 
 fuzzer_test("color_transform_fuzztest") {
   sources = [
     "color_transform_fuzzer.cc",
   ]
   deps = [
     ":gfx",
   ]
   libfuzzer_options = [ "max_len=1024" ]
 }