Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2871833003: Move more classes to use WebLocalFrameBase from WebLocalFrameImpl. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more classes to use WebLocalFrameBase from WebLocalFrameImpl. These use cases do not require any further virtual methods to be declared in WebLocalFrameBase - they simply call the existing Client() method. This CL updates: - AudioOutputDeviceClientImpl.cpp - MediaKeysClientImpl.cpp - WebPluginContainerImpl.cpp BUG=708879 Review-Url: https://codereview.chromium.org/2871833003 Cr-Commit-Position: refs/heads/master@{#470279} Committed: https://chromium.googlesource.com/chromium/src/+/88ffa876760cfe39fc790bc1dbd901aff0e3cede

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/MediaKeysClientImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
slangley
3 years, 7 months ago (2017-05-09 07:43:48 UTC) #3
tkent
lgtm
3 years, 7 months ago (2017-05-09 07:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871833003/1
3 years, 7 months ago (2017-05-09 07:46:32 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 11:14:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/88ffa876760cfe39fc790bc1dbd9...

Powered by Google App Engine
This is Rietveld 408576698