Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2871733005:
cryptohome: Add UMA stats for the cause of migration failures. (Closed)
Descriptioncryptohome: Add UMA stats for the cause of migration failures.
To analyze the trend of reported failures in more detail,
this CL adds the metrics for type of failures (error code,
on which file operation it happened, and the rough category
of file paths.)
The metrics are going to be used from Chrome OS cryptohomed.
See: https://chromium-review.googlesource.com/#/c/500238/
BUG=719318
Review-Url: https://codereview.chromium.org/2871733005
Cr-Commit-Position: refs/heads/master@{#470808}
Committed: https://chromium.googlesource.com/chromium/src/+/aed44111a1f008907b532b9232b6075f44e598f2
Patch Set 1 #Patch Set 2 : . #
Total comments: 4
Patch Set 3 : Reflect review comments #Patch Set 4 : . #Messages
Total messages: 32 (27 generated)
The CQ bit was checked by kinaba@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kinaba@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kinaba@chromium.org changed reviewers: + jwd@chromium.org
PTAL The metrics are going to be used from Chrome OS (https://chromium-review.googlesource.com/#/c/500238/)
Please add a link to the cl that added the logging code to the CL description. LGTM with nits. https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9529: + from ecryptfs to ext4-crypto has failed. This is logged ocne the migration nit: ocne -> once https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9530: + encounted a file I/O error. nit: encounted -> encounters or encountered (same for both the other summaries.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== cryptohome: Add UMA stats for the cause of migration failures. BUG=719318 ========== to ========== cryptohome: Add UMA stats for the cause of migration failures. The metrics are going to be used from Chrome OS cryptohomed. See: https://chromium-review.googlesource.com/#/c/500238/ BUG=719318 ==========
Description was changed from ========== cryptohome: Add UMA stats for the cause of migration failures. The metrics are going to be used from Chrome OS cryptohomed. See: https://chromium-review.googlesource.com/#/c/500238/ BUG=719318 ========== to ========== cryptohome: Add UMA stats for the cause of migration failures. To analyze the trend of reported failures in more detail, this CL adds the metrics for type of failures (error code, on which file operation it happened, and the rough category of file paths.) The metrics are going to be used from Chrome OS cryptohomed. See: https://chromium-review.googlesource.com/#/c/500238/ BUG=719318 ==========
The CQ bit was checked by kinaba@chromium.org to run a CQ dry run
thanks for the review https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9529: + from ecryptfs to ext4-crypto has failed. This is logged ocne the migration On 2017/05/09 18:49:29, jwd wrote: > nit: ocne -> once Done. https://codereview.chromium.org/2871733005/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:9530: + encounted a file I/O error. On 2017/05/09 18:49:29, jwd wrote: > nit: encounted -> encounters or encountered (same for both the other summaries. Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by kinaba@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kinaba@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kinaba@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org Link to the patchset: https://codereview.chromium.org/2871733005/#ps60001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494477140189180,
"parent_rev": "4eab0482d9c544b1473f49f21c6fac6d1b23bd62", "commit_rev":
"aed44111a1f008907b532b9232b6075f44e598f2"}
Message was sent while issue was closed.
Description was changed from ========== cryptohome: Add UMA stats for the cause of migration failures. To analyze the trend of reported failures in more detail, this CL adds the metrics for type of failures (error code, on which file operation it happened, and the rough category of file paths.) The metrics are going to be used from Chrome OS cryptohomed. See: https://chromium-review.googlesource.com/#/c/500238/ BUG=719318 ========== to ========== cryptohome: Add UMA stats for the cause of migration failures. To analyze the trend of reported failures in more detail, this CL adds the metrics for type of failures (error code, on which file operation it happened, and the rough category of file paths.) The metrics are going to be used from Chrome OS cryptohomed. See: https://chromium-review.googlesource.com/#/c/500238/ BUG=719318 Review-Url: https://codereview.chromium.org/2871733005 Cr-Commit-Position: refs/heads/master@{#470808} Committed: https://chromium.googlesource.com/chromium/src/+/aed44111a1f008907b532b9232b6... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/aed44111a1f008907b532b9232b6... |
