Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2871713002: Change build.py to be like ninja.py and only use a single GN/Ninja invocation to cross-build the SD… (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change build.py to be like ninja.py and only use a single GN/Ninja invocation to cross-build the SDK. This step alone would fix #29580. This breaks cross-building the SDK with GYP. Remove hack in bin/snapshot_utils.cc that avoided building a true app-jit snapshot for ARM, ARM64 and MIPS because of the multiple invocations above. Add GN flags to choose to build script snapshots instead of app-jit snapshots, avoiding a slow training run inside a simulator. Fixes #29580. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/98d31056a79a40bca4590b429bc8e9e3ab766e69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -64 lines) Patch
M runtime/bin/snapshot_utils.cc View 2 chunks +15 lines, -14 lines 0 comments Download
M tools/build.py View 3 chunks +4 lines, -44 lines 0 comments Download
M tools/gn.py View 1 chunk +7 lines, -0 lines 0 comments Download
M utils/application_snapshot.gni View 2 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 7 months ago (2017-05-08 18:31:20 UTC) #2
zra
lgtm
3 years, 7 months ago (2017-05-08 19:30:58 UTC) #3
rmacnak
3 years, 7 months ago (2017-05-08 20:06:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
98d31056a79a40bca4590b429bc8e9e3ab766e69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698