Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn.py

Issue 2871713002: Change build.py to be like ninja.py and only use a single GN/Ninja invocation to cross-build the SD… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/build.py ('k') | utils/application_snapshot.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 5972295692541c14a777e130559c371e80c27466..d3d5f6aeaa52e1fcbdfb9d79cf54112a9f6d38d5 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -129,6 +129,13 @@ def ToGnArgs(args, mode, arch, target_os):
# dart_bootstrap if the prebuilt SDK doesn't work.
gn_args['dart_host_pub_exe'] = ""
+ if arch != HostCpuForArch(arch):
+ # Training an app-jit snapshot under a simulator is slow. Use script
+ # snapshots instead.
+ gn_args['dart_snapshot_kind'] = 'script'
+ else:
+ gn_args['dart_snapshot_kind'] = 'app-jit'
+
# We only want the fallback root certs in the standalone VM on
# Linux and Windows.
if gn_args['target_os'] in ['linux', 'win']:
« no previous file with comments | « tools/build.py ('k') | utils/application_snapshot.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698