Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2871703003: Clear the state of scroll and selection onmouseup (Closed)

Created:
3 years, 7 months ago by Navid Zolghadr
Modified:
3 years, 7 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the state of scroll and selection onmouseup Clear the state of scroll and selection when mouse is released regardless of what js has done on mouseup including preventDefault. BUG=686209 Review-Url: https://codereview.chromium.org/2871703003 Cr-Commit-Position: refs/heads/master@{#471883} Committed: https://chromium.googlesource.com/chromium/src/+/212a2f1bb04d49d123035f2338332d5afe0ee075

Patch Set 1 #

Patch Set 2 : Update the test #

Total comments: 1

Patch Set 3 : Fix the default action of mouseup #

Patch Set 4 : Remove redundant parameter #

Patch Set 5 : Remove redundant parameter #

Patch Set 6 : Remove redundant parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlerTest.cpp View 1 3 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
Navid Zolghadr
3 years, 7 months ago (2017-05-08 18:48:53 UTC) #4
dtapuska
https://codereview.chromium.org/2871703003/diff/20001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/2871703003/diff/20001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1007 third_party/WebKit/Source/core/input/EventHandler.cpp:1007: mouse_event_manager_->HandleMouseReleaseEvent(mev); What about preventing the paste on middle click ...
3 years, 7 months ago (2017-05-08 18:54:07 UTC) #5
Navid Zolghadr
ptal
3 years, 7 months ago (2017-05-09 15:41:06 UTC) #14
dtapuska
On 2017/05/09 15:41:06, Navid Zolghadr wrote: > ptal lgtm
3 years, 7 months ago (2017-05-09 19:47:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871703003/100001
3 years, 7 months ago (2017-05-09 19:50:55 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449149)
3 years, 7 months ago (2017-05-10 03:17:49 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871703003/100001
3 years, 7 months ago (2017-05-10 17:40:30 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450398)
3 years, 7 months ago (2017-05-10 18:50:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871703003/100001
3 years, 7 months ago (2017-05-15 18:01:08 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 20:23:39 UTC) #30
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/212a2f1bb04d49d123035f233833...

Powered by Google App Engine
This is Rietveld 408576698