Revert of Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_

Revert of Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_ (patchset #2 id:20001 of https://codereview.chromium.org/2854853006/ )

Reason for revert:
Moving CheckCompleted() call to HTMLFrameOwnerElement::ClearContentFrame() appears to be causing script to run in a ScriptForbiddenScope. See crbug.com/719397

Original issue's description:
> Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_
> 
> Clear() is full of strange, old logic. Several clauses are outright unnecessary, or have better-encapsulated homes.
> 
> check_timer_ appears to have two uses, one of which is vestigial, the other of which can be better-situated to not require a timer.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2854853006
> Cr-Commit-Position: refs/heads/master@{#469774}
> Committed: https://chromium.googlesource.com/chromium/src/+/2081f48578f7d6ff49d468a76e471f2b90f78178

TBR=dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2871703002
Cr-Commit-Position: refs/heads/master@{#470176}
Committed: https://chromium.googlesource.com/chromium/src/+/f9ec861dd439fa98154ae7928f1472bd6e4d2c88

[Nate Chapin, 2017-05-08 18:05:59]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2017-05-08 18:05:59]

Created Revert of Simplify FrameLoader::Clear(), remove
FrameLoader::check_timer_

[commit-bot: I haz the power, 2017-05-08 18:06:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-05-08 20:20:21]

LGTM

[commit-bot: I haz the power, 2017-05-08 20:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:37:33]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2017-05-08 21:03:11]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:04:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:58:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494277391347020, "parent_rev":
"3908bdac06d50f5998807a973de59f664490eda7", "commit_rev":
"f9ec861dd439fa98154ae7928f1472bd6e4d2c88"}

[commit-bot: I haz the power, 2017-05-09 03:58:19]

Description was changed from

==========
Revert of Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_
(patchset #2 id:20001 of https://codereview.chromium.org/2854853006/ )

Reason for revert:
Moving CheckCompleted() call to HTMLFrameOwnerElement::ClearContentFrame()
appears to be causing script to run in a ScriptForbiddenScope. See
crbug.com/719397

Original issue's description:
> Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_
> 
> Clear() is full of strange, old logic. Several clauses are outright
unnecessary, or have better-encapsulated homes.
> 
> check_timer_ appears to have two uses, one of which is vestigial, the other of
which can be better-situated to not require a timer.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2854853006
> Cr-Commit-Position: refs/heads/master@{#469774}
> Committed:
https://chromium.googlesource.com/chromium/src/+/2081f48578f7d6ff49d468a76e47...

TBR=dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
==========

to

==========
Revert of Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_
(patchset #2 id:20001 of https://codereview.chromium.org/2854853006/ )

Reason for revert:
Moving CheckCompleted() call to HTMLFrameOwnerElement::ClearContentFrame()
appears to be causing script to run in a ScriptForbiddenScope. See
crbug.com/719397

Original issue's description:
> Simplify FrameLoader::Clear(), remove FrameLoader::check_timer_
> 
> Clear() is full of strange, old logic. Several clauses are outright
unnecessary, or have better-encapsulated homes.
> 
> check_timer_ appears to have two uses, one of which is vestigial, the other of
which can be better-situated to not require a timer.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2854853006
> Cr-Commit-Position: refs/heads/master@{#469774}
> Committed:
https://chromium.googlesource.com/chromium/src/+/2081f48578f7d6ff49d468a76e47...

TBR=dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2871703002
Cr-Commit-Position: refs/heads/master@{#470176}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9ec861dd439fa98154ae7928f14...
==========

[commit-bot: I haz the power, 2017-05-09 03:58:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9ec861dd439fa98154ae7928f14...