Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2871673005: [codesearch] Add phase to builders in 'chromium.infra.codesearch' (Closed)

Created:
3 years, 7 months ago by shenghuazhang
Modified:
3 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[codesearch] Add phase to builders in 'chromium.infra.codesearch' Builder 'codesearch-gen-chromium-chromiumos' has duplicated compilation (chromiumos, linux). Add phases to mb config to enable double compile in recipe. BUG=718658 Review-Url: https://codereview.chromium.org/2871673005 Cr-Commit-Position: refs/heads/master@{#470668} Committed: https://chromium.googlesource.com/chromium/src/+/290f2bede4df8363122591f27baf118f227841a5

Patch Set 1 #

Total comments: 2

Patch Set 2 : chromeos instead of chromiumos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
shenghuazhang
3 years, 7 months ago (2017-05-09 21:31:57 UTC) #2
jbudorick
lgtm
3 years, 7 months ago (2017-05-09 23:08:19 UTC) #3
jbudorick
https://codereview.chromium.org/2871673005/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2871673005/diff/1/tools/mb/mb_config.pyl#newcode264 tools/mb/mb_config.pyl:264: 'chromiumos': 'codesearch_gen_chromium_chromiumos_bot', er, actually, you've got 'chromiumos' here and ...
3 years, 7 months ago (2017-05-09 23:15:19 UTC) #4
shenghuazhang
https://codereview.chromium.org/2871673005/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2871673005/diff/1/tools/mb/mb_config.pyl#newcode264 tools/mb/mb_config.pyl:264: 'chromiumos': 'codesearch_gen_chromium_chromiumos_bot', On 2017/05/09 23:15:18, jbudorick wrote: > er, ...
3 years, 7 months ago (2017-05-09 23:21:22 UTC) #5
jbudorick
lgtm
3 years, 7 months ago (2017-05-09 23:30:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871673005/20001
3 years, 7 months ago (2017-05-09 23:34:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 01:38:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871673005/20001
3 years, 7 months ago (2017-05-10 18:17:19 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 19:36:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/290f2bede4df8363122591f27baf...

Powered by Google App Engine
This is Rietveld 408576698