Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2871673004: Fix Onscreen Keyboard crash in --mus. (Closed)

Created:
3 years, 7 months ago by Hadi
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, oka+watchvk_chromium.org, groby+virtualkb_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Onscreen Keyboard crash in --mus. OzonePlatform is instantiated in mus-ws in --mus and we don't have access to it in ui::KeyboardController. Trying to access OzonePlatform here failed the DCHECK() in ui::OzonePlatform::GetInstance(). BUG=719540 Review-Url: https://codereview.chromium.org/2871673004 Cr-Commit-Position: refs/heads/master@{#470462} Committed: https://chromium.googlesource.com/chromium/src/+/e69195aa6646b2f6e481e5f1e0fbc82cc807d58a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/keyboard/keyboard_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Hadi
PTAL.
3 years, 7 months ago (2017-05-09 17:57:26 UTC) #3
sadrul
lgtm
3 years, 7 months ago (2017-05-10 01:19:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871673004/1
3 years, 7 months ago (2017-05-10 04:44:46 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 04:55:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e69195aa6646b2f6e481e5f1e0fb...

Powered by Google App Engine
This is Rietveld 408576698