Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary (2nd landing)

Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary (2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  --> OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632
Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
TBR=reillyg@chromium.org (reviewer of the original CL)

Review-Url: https://codereview.chromium.org/2871653003 .
Cr-Commit-Position: refs/branch-heads/3071@{#463}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/b4d3ac8136a52dbdcd521ac47fefb55bda7dbe88

[mcasas, 2017-05-08 21:22:13]

Description was changed from

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
==========

to

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
==========

[mcasas, 2017-05-08 21:23:03]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:23:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 21:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 21:23:53]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mcasas, 2017-05-08 21:25:38]

Description was changed from

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
TBR=reillyg@chromium.org (reviewer of the original CL)
==========

[mcasas, 2017-05-08 21:26:26]

Description was changed from

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
TBR=reillyg@chromium.org (reviewer of the original CL)
==========

to

==========
Image Capture: teach takePhoto() to accept an optional PhotoSettings dictionary
(2nd landing)

[Note] The first landing was reverted due to a wrong rebase on
my side: forgot to close a {   :-P

This CL:
- Adds an optional PhotoSettings arg to takePhoto(),

- cleanup: the 3 private methods used to receive mojo callbacks
 (OnPhotoCapabilities, OnSetOptions and OnTakePhoto) get a Mojo
prefix, for clarity.

- adds a |trigger_take_photo| argument to setOptions() and a few
others that pass it along; takePhoto() uses it to setOptions() when
appropriate.  The sequence of method calls in ImageCapture.cpp then
would be:
 - without options
   takePhoto() -> OnMojoTakePhoto()
 - with options:
   takePhoto(options) -> setOptions(trigger_take_photo == true)  -->
OnMojoSetOptions(true) --> OnMojoPhotoCapabilities(true) --> OnMojoTakePhoto()

- methods OnCapabilitiesUpdate() and OnCapabilitiesUpdateInternal()
(which are essentially the same thing) are merged and the resulting
method renamed to UpdateMediaTrackCapabilities() to make more
evident what it does.

BUG=718632

Review-Url: https://codereview.chromium.org/2865563002
Cr-Commit-Position: refs/heads/master@{#469766}
NOPRESUBMIT=true
NOTRY=true
TBR=reillyg@chromium.org (reviewer of the original CL)

Review-Url: https://codereview.chromium.org/2871653003 .
Cr-Commit-Position: refs/branch-heads/3071@{#463}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4d3ac8136a52dbdcd521ac47fef...
==========

[mcasas, 2017-05-08 21:26:27]

Committed patchset #1 (id:1) manually as
b4d3ac8136a52dbdcd521ac47fefb55bda7dbe88 (presubmit successful).