Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2871643005: Disallow mixing of Canadian Syllabary and [a-z] (Closed)

Created:
3 years, 7 months ago by jungshik at Google
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow mixing of Canadian Syllabary and [a-z] BUG=719199 TEST=components_unittests --gtest_filter=*IDNToUn* Review-Url: https://codereview.chromium.org/2871643005 Cr-Commit-Position: refs/heads/master@{#471538} Committed: https://chromium.googlesource.com/chromium/src/+/e2fde40094b4c9b56a7e6342ab1c8bbe75381761

Patch Set 1 #

Total comments: 3

Patch Set 2 : delete unnecesary check #

Patch Set 3 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M components/url_formatter/url_formatter.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M components/url_formatter/url_formatter_unittest.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
jungshik at Google
PTAL. Thanks
3 years, 7 months ago (2017-05-09 08:33:10 UTC) #2
jungshik at Google
https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc#newcode436 components/url_formatter/url_formatter.cc:436: CHECK(U_SUCCESS(status)); This will be removed.
3 years, 7 months ago (2017-05-09 20:28:24 UTC) #3
Matt Giuca
https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc#newcode436 components/url_formatter/url_formatter.cc:436: CHECK(U_SUCCESS(status)); On 2017/05/09 20:28:22, jungshik at Google wrote: > ...
3 years, 7 months ago (2017-05-10 00:25:59 UTC) #4
Peter Kasting
LGTM but I share Matt's question about the CHECK. https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc File components/url_formatter/url_formatter.cc (right): https://codereview.chromium.org/2871643005/diff/1/components/url_formatter/url_formatter.cc#newcode436 components/url_formatter/url_formatter.cc:436: ...
3 years, 7 months ago (2017-05-10 20:23:53 UTC) #5
jungshik at Google
On 2017/05/10 20:23:53, Peter Kasting wrote: > LGTM but I share Matt's question about the ...
3 years, 7 months ago (2017-05-12 23:07:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871643005/20001
3 years, 7 months ago (2017-05-12 23:12:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/410430)
3 years, 7 months ago (2017-05-12 23:55:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871643005/40001
3 years, 7 months ago (2017-05-13 00:34:22 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 01:57:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e2fde40094b4c9b56a7e6342ab1c...

Powered by Google App Engine
This is Rietveld 408576698