Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2871643003: [CUPS] Remove the string in manufaturer-model-dialog. (Closed)

Created:
3 years, 7 months ago by xdai1
Modified:
3 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Remove the string in manufaturer-model-dialog. BUG=717584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2871643003 Cr-Commit-Position: refs/heads/master@{#470412} Committed: https://chromium.googlesource.com/chromium/src/+/ccedf2b29faaf7d66f4270a6e2a8cdf70a6d2f37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
3 years, 7 months ago (2017-05-08 21:43:15 UTC) #3
michaelpg
lgtm
3 years, 7 months ago (2017-05-08 22:59:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871643003/1
3 years, 7 months ago (2017-05-08 23:20:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/365556)
3 years, 7 months ago (2017-05-09 00:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871643003/1
3 years, 7 months ago (2017-05-09 17:55:58 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 20:18:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccedf2b29faaf7d66f4270a6e2a8...

Powered by Google App Engine
This is Rietveld 408576698