Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2871603002:
Manually convert VisualViewportTest.cpp to new blink style. (Closed)
DescriptionManually convert VisualViewportTest.cpp to new blink style.
BUG=675877
NOTRY=true
Review-Url: https://codereview.chromium.org/2871603002
Cr-Commit-Position: refs/heads/master@{#470118}
Committed: https://chromium.googlesource.com/chromium/src/+/4c0e369d74f4406b82fcb38581cd1a1abf3d7559
Patch Set 1 #Patch Set 2 : forgot frame() #Patch Set 3 : . #Patch Set 4 : . #Patch Set 5 : . #Messages
Total messages: 27 (22 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + dcheng@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Spot checked, LGTM (One thing of note might be that the method named WebViewImpl might break once the function is changed to return WebViewImpl*; I suppose we can just fix it when we finish the WebViewImpl migration into core though)
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2871603002/#ps80001 (title: ".")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== Manually convert VisualViewportTest.cpp to new blink style. BUG=675877 ========== to ========== Manually convert VisualViewportTest.cpp to new blink style. BUG=675877 NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494276298955840,
"parent_rev": "88ef328f50e31c63ff7f9261f25cbffabda136f3", "commit_rev":
"4c0e369d74f4406b82fcb38581cd1a1abf3d7559"}
Message was sent while issue was closed.
Description was changed from ========== Manually convert VisualViewportTest.cpp to new blink style. BUG=675877 NOTRY=true ========== to ========== Manually convert VisualViewportTest.cpp to new blink style. BUG=675877 NOTRY=true Review-Url: https://codereview.chromium.org/2871603002 Cr-Commit-Position: refs/heads/master@{#470118} Committed: https://chromium.googlesource.com/chromium/src/+/4c0e369d74f4406b82fcb38581cd... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/4c0e369d74f4406b82fcb38581cd... |
