Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt

Issue 2871593003: DevTools: correctly parse srcset attribute before linkifying urls (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
index f116e5fd8689519f0b0253373c4582594ccc8449..e8ba8b3293b37963ef0d0cde16e1186825ae0517 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt
@@ -1,11 +1,18 @@
Tests that you can click and hover on links in attributes.
- a link
+ a link
luoe 2017/05/08 22:14:44 No functional change on this line. It's only due
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-1</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x92dp.png</span> 1x, <span class="devtools-link devtools-link-prevent-click">./​2x/​googlelogo_color_272x92dp.png</span> 2x</span>"</span>&gt;</span>​</span>
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-2</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x92dp.png</span></span>"</span>&gt;</span>​</span>
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">source</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-3</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(min-width:​ 650px)​</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</span></span>"</span>&gt;</span>​</span>
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">source</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-4</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(min-width:​ 465px)​</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png</span></span>"</span>&gt;</span>​</span>
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">source</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-5</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(min-width:​ 400px)​</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</span> 2x</span>"</span>&gt;</span>​</span>
<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-6</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">src</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-small.png</span></span>"</span>&gt;</span>​</span>
-<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">a</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-7</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">href</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click" target="_blank">http:​/​/​www.google.com</span></span>"</span>&gt;</span>​<span class="webkit-html-text-node">a link</span>​<span class="webkit-html-tag">&lt;<span class="webkit-html-close-tag-name">/a</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-7</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png,</span> <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</span> 2x</span>"</span>&gt;</span>​</span>
dgozman 2017/05/08 23:37:40 Can we rewrite this test to be readable?
luoe 2017/05/09 02:53:18 Done.
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-8</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png</span> 1x, <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</span> 2x</span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-9</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png</span> 1x, <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</span> 2x</span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-10</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">data:​,abc</span></span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-11</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x</span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-12</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x, <span class="devtools-link devtools-link-prevent-click">data:​,def</span> 2x</span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-13</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x, <span class="devtools-link devtools-link-prevent-click">data:​,def</span> 2x</span>"</span>&gt;</span>​</span>
+<span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-html-tag-name">a</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify-14</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-attribute-name">href</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click" target="_blank">http:​/​/​www.google.com</span></span>"</span>&gt;</span>​<span class="webkit-html-text-node">a link</span>​<span class="webkit-html-tag">&lt;<span class="webkit-html-close-tag-name">/a</span>&gt;</span>​</span>
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698