Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes-expected.txt

Issue 2871593003: DevTools: correctly parse srcset attribute before linkifying urls (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Tests that you can click and hover on links in attributes. 1 Tests that you can click and hover on links in attributes.
2 2
3 a link 3 a link
luoe 2017/05/08 22:14:44 No functional change on this line. It's only due
4 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-1</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x9 2dp.png</span> 1x, <span class="devtools-link devtools-link-prevent-click">./​2x /​googlelogo_color_272x92dp.png</span> 2x</span>"</span>&gt;</span>​</span> 4 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-1</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x9 2dp.png</span> 1x, <span class="devtools-link devtools-link-prevent-click">./​2x /​googlelogo_color_272x92dp.png</span> 2x</span>"</span>&gt;</span>​</span>
5 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-2</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x9 2dp.png</span></span>"</span>&gt;</span>​</span> 5 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-2</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​1x/​googlelogo_color_272x9 2dp.png</span></span>"</span>&gt;</span>​</span>
6 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-3</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 650px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large. png</span></span>"</span>&gt;</span>​</span> 6 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-3</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 650px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large. png</span></span>"</span>&gt;</span>​</span>
7 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-4</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 465px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium .png</span></span>"</span>&gt;</span>​</span> 7 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-4</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 465px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium .png</span></span>"</span>&gt;</span>​</span>
8 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-5</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 400px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large. png</span> 2x</span>"</span>&gt;</span>​</span> 8 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">source</span> <span class="webkit-html-attribute"><span class="webk it-html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">li nkify-5</span>"</span> <span class="webkit-html-attribute"><span class="webkit-h tml-attribute-name">media</span>=​"<span class="webkit-html-attribute-value">(mi n-width:​ 400px)​</span>"</span> <span class="webkit-html-attribute"><span class ="webkit-html-attribute-name">srcset</span>=​"<span class="webkit-html-attribute -value"><span class="devtools-link devtools-link-prevent-click">./​kitten-large. png</span> 2x</span>"</span>&gt;</span>​</span>
9 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-6</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">src</span>=​"<span class="webkit-html-attribute-value"><span cl ass="devtools-link devtools-link-prevent-click">./​kitten-small.png</span></span >"</span>&gt;</span>​</span> 9 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-6</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">src</span>=​"<span class="webkit-html-attribute-value"><span cl ass="devtools-link devtools-link-prevent-click">./​kitten-small.png</span></span >"</span>&gt;</span>​</span>
10 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">a</span> <span class="webkit-html-attribute"><span class="webkit-ht ml-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify -7</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html-a ttribute-name">href</span>=​"<span class="webkit-html-attribute-value"><span cla ss="devtools-link devtools-link-prevent-click" target="_blank">http:​/​/​www.goo gle.com</span></span>"</span>&gt;</span>​<span class="webkit-html-text-node">a l ink</span>​<span class="webkit-html-tag">&lt;<span class="webkit-html-close-tag- name">/a</span>&gt;</span>​</span> 10 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-7</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png,</span> <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</spa n> 2x</span>"</span>&gt;</span>​</span>
dgozman 2017/05/08 23:37:40 Can we rewrite this test to be readable?
luoe 2017/05/09 02:53:18 Done.
11 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-8</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png</span> 1 x, <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</ span> 2x</span>"</span>&gt;</span>​</span>
12 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-9</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html -attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><span class="devtools-link devtools-link-prevent-click">./​kitten-medium.png</span> 1 x, <span class="devtools-link devtools-link-prevent-click">./​kitten-large.png</ span> 2x</span>"</span>&gt;</span>​</span>
13 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-10</span>"</span> <span class="webkit-html-attribute"><span class="webkit-htm l-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><spa n class="devtools-link devtools-link-prevent-click">data:​,abc</span></span>"</s pan>&gt;</span>​</span>
14 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-11</span>"</span> <span class="webkit-html-attribute"><span class="webkit-htm l-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><spa n class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x</span>" </span>&gt;</span>​</span>
15 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-12</span>"</span> <span class="webkit-html-attribute"><span class="webkit-htm l-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><spa n class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x, <span class="devtools-link devtools-link-prevent-click">data:​,def</span> 2x</span>"</ span>&gt;</span>​</span>
16 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">img</span> <span class="webkit-html-attribute"><span class="webkit- html-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linki fy-13</span>"</span> <span class="webkit-html-attribute"><span class="webkit-htm l-attribute-name">srcset</span>=​"<span class="webkit-html-attribute-value"><spa n class="devtools-link devtools-link-prevent-click">data:​,abc</span> 1x, <span class="devtools-link devtools-link-prevent-click">data:​,def</span> 2x</span>"</ span>&gt;</span>​</span>
17 <span class="highlight"><span class="webkit-html-tag">&lt;<span class="webkit-ht ml-tag-name">a</span> <span class="webkit-html-attribute"><span class="webkit-ht ml-attribute-name">id</span>=​"<span class="webkit-html-attribute-value">linkify -14</span>"</span> <span class="webkit-html-attribute"><span class="webkit-html- attribute-name">href</span>=​"<span class="webkit-html-attribute-value"><span cl ass="devtools-link devtools-link-prevent-click" target="_blank">http:​/​/​www.go ogle.com</span></span>"</span>&gt;</span>​<span class="webkit-html-text-node">a link</span>​<span class="webkit-html-tag">&lt;<span class="webkit-html-close-tag -name">/a</span>&gt;</span>​</span>
11 18
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements/elements-linkify-attributes.html ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('j') | third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698