Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2871583004: Rename --enable-default-media-session to --enable-audio-focus. (Closed)

Created:
3 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 7 months ago
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, alokp+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, jam, je_julie, lcwu+watch_chromium.org, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename --enable-default-media-session to --enable-audio-focus. The flag matches reality and will allow to introduce a flag that will enable the MediaSession code without turning on the audio focus behaviour. BUG=719968 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2871583004 Cr-Commit-Position: refs/heads/master@{#470965} Committed: https://chromium.googlesource.com/chromium/src/+/ff56c0909be1a23d43a31ba9acb45964cd1a3256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -50 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/session/audio_focus_delegate_default.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/audio_focus_delegate_default_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/audio_focus_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_controllers_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/pepper_playback_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/session/pepper_player_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
mlamouri (slow - plz ping)
slan@, PTAL at: chromecast/browser/cast_browser_main_parts.cc dmazzoni, PTAL at: chrome/browser/chromeos/accessibility/accessibility_manager.cc chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js chrome/browser/resources/chromeos/chromevox/cvox2/background/media_automation_handler.js hubbe@, PTAL at: media/base/media_switches.cc media/base/media_switches.h ...
3 years, 7 months ago (2017-05-09 15:02:48 UTC) #5
slan
cast lgtm
3 years, 7 months ago (2017-05-09 15:18:58 UTC) #7
dmazzoni
lgtm for chromevox, but +dtseng as FYI in case any docs or other material needs ...
3 years, 7 months ago (2017-05-09 17:13:55 UTC) #9
hubbe
LGTM (but would prefer using base::Feature)
3 years, 7 months ago (2017-05-10 17:45:18 UTC) #12
mlamouri (slow - plz ping)
On 2017/05/10 at 17:45:18, hubbe wrote: > LGTM (but would prefer using base::Feature) I would ...
3 years, 7 months ago (2017-05-11 08:54:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871583004/1
3 years, 7 months ago (2017-05-11 08:55:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/441819)
3 years, 7 months ago (2017-05-11 13:07:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871583004/1
3 years, 7 months ago (2017-05-11 13:41:56 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 15:31:58 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff56c0909be1a23d43a31ba9acb4...

Powered by Google App Engine
This is Rietveld 408576698