Add VoiceInteractionFrameworkHost::SetMetalayerEnabled

Add VoiceInteractionFrameworkHost::SetMetalayerEnabled

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side).

Review-Url: https://codereview.chromium.org/2871583003
Cr-Commit-Position: refs/heads/master@{#471051}
Committed: https://chromium.googlesource.com/chromium/src/+/44ada2a222773bb39be4c8486285afa0900886d4

[Vladislav Kaznacheev, 2017-05-09 18:12:31]

Description was changed from

==========
Add VoiceInteractionFrameworkHost::SetScreenshotEnabled

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side.
==========

to

==========
Add VoiceInteractionFrameworkHost::SetMetalayerEnabled

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side).
==========

[Vladislav Kaznacheev, 2017-05-09 18:44:25]

kaznacheev@chromium.org changed reviewers:
+ estark@chromium.org, xiaohuic@chromium.org

[Vladislav Kaznacheev, 2017-05-09 18:44:26]

Please review:

estark@ *.mojom

xiaohuic@: chrome/browser/chromeos/arc/voice_interaction/*

[xc, 2017-05-09 19:53:14]

lgtm

[Luis Héctor Chávez, 2017-05-09 19:59:49]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2017-05-09 19:59:50]

drive-by

https://codereview.chromium.org/2871583003/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2871583003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:63:
bool metalayer_enabled_;
nit: initialize this to false here instead of the ctor.

[kaznacheev, 2017-05-09 20:53:36]

kaznacheev@google.com changed reviewers:
+ kaznacheev@google.com

[kaznacheev, 2017-05-09 20:53:37]

https://codereview.chromium.org/2871583003/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2871583003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:63:
bool metalayer_enabled_;
On 2017/05/09 19:59:50, Luis Héctor Chávez wrote:
> nit: initialize this to false here instead of the ctor.

Done.

[estark, 2017-05-11 01:14:13]

https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
components/arc/common/voice_interaction_framework.mojom:27:
[MinVersion=3]SetMetalayerEnabled@3(bool enabled);
Does untrusted code call this, or only trusted code? Naively, it sounds bad if
untrusted code can enable screenshot-taking and get a screenshot of the current
focused window.

[Vladislav Kaznacheev, 2017-05-11 18:46:11]

On 2017/05/11 01:14:13, estark wrote:
>
https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
> File components/arc/common/voice_interaction_framework.mojom (right):
> 
>
https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
> components/arc/common/voice_interaction_framework.mojom:27:
> [MinVersion=3]SetMetalayerEnabled@3(bool enabled);
> Does untrusted code call this, or only trusted code? Naively, it sounds bad if
> untrusted code can enable screenshot-taking and get a screenshot of the
current
> focused window.

This method is only called from the system server process on the Android
container side.

[estark, 2017-05-11 18:47:27]

On 2017/05/11 18:46:11, Vladislav Kaznacheev wrote:
> On 2017/05/11 01:14:13, estark wrote:
> >
>
https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
> > File components/arc/common/voice_interaction_framework.mojom (right):
> > 
> >
>
https://codereview.chromium.org/2871583003/diff/40001/components/arc/common/v...
> > components/arc/common/voice_interaction_framework.mojom:27:
> > [MinVersion=3]SetMetalayerEnabled@3(bool enabled);
> > Does untrusted code call this, or only trusted code? Naively, it sounds bad
if
> > untrusted code can enable screenshot-taking and get a screenshot of the
> current
> > focused window.
> 
> This method is only called from the system server process on the Android
> container side.

Ok, thanks. LGTM.

[Vladislav Kaznacheev, 2017-05-11 18:53:51]

The CQ bit was checked by kaznacheev@chromium.org

[Vladislav Kaznacheev, 2017-05-11 18:53:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaohuic@chromium.org
Link to the patchset: https://codereview.chromium.org/2871583003/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-05-11 18:55:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 19:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 19:13:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Vladislav Kaznacheev, 2017-05-11 19:16:58]

lhchavez@, please PTAL, need your OWNER's LGTM

[Luis Héctor Chávez, 2017-05-11 19:49:54]

lgtm

[kaznacheev, 2017-05-11 19:56:57]

The CQ bit was checked by kaznacheev@google.com

[commit-bot: I haz the power, 2017-05-11 19:58:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 20:06:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494532617078750,
"parent_rev": "8c4e6ca1e9ffd25f04505b1e451cf26e19c8101c", "commit_rev":
"44ada2a222773bb39be4c8486285afa0900886d4"}

[commit-bot: I haz the power, 2017-05-11 20:06:45]

Description was changed from

==========
Add VoiceInteractionFrameworkHost::SetMetalayerEnabled

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side).
==========

to

==========
Add VoiceInteractionFrameworkHost::SetMetalayerEnabled

Make Metalayer mode visibility dependent on the container side
setting.

BUG=b:37997351
TEST=Manual ("Metalayer mode" visible only when screenshots
  are enabled on the container side).

Review-Url: https://codereview.chromium.org/2871583003
Cr-Commit-Position: refs/heads/master@{#471051}
Committed:
https://chromium.googlesource.com/chromium/src/+/44ada2a222773bb39be4c8486285...
==========

[commit-bot: I haz the power, 2017-05-11 20:06:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/44ada2a222773bb39be4c8486285...