[MD Bookmarks] Make dragging update selected items.

[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2871573004
Cr-Commit-Position: refs/heads/master@{#471657}
Committed: https://chromium.googlesource.com/chromium/src/+/b8cc19e2ca0b494668eb91df0eb054f3d94b639e

[calamity, 2017-05-09 06:43:35]

Description was changed from

==========
[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG=692843
==========

to

==========
[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-05-12 04:11:32]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2017-05-12 04:11:32]

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_manager.js (left):

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_manager.js:374: // TODO(calamity):
Handle dropping to an empty bookmark list.
This was taken care of in another CL and just getting cleaned up here.

[tsergeant, 2017-05-12 06:03:24]

lgtm

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_manager.js (right):

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_manager.js:416:
store.handleAction(bookmarks.actions.deselectItems());
You'll need to rebase to pick up the rename of this function to 'dispatch'

[calamity, 2017-05-12 06:32:42]

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_bookmarks/dnd_manager.js (right):

https://codereview.chromium.org/2871573004/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_bookmarks/dnd_manager.js:416:
store.handleAction(bookmarks.actions.deselectItems());
On 2017/05/12 06:03:24, tsergeant wrote:
> You'll need to rebase to pick up the rename of this function to 'dispatch'

Done.

[calamity, 2017-05-12 06:32:48]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-05-12 06:32:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2871573004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-12 06:33:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 07:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 07:18:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2017-05-15 02:42:38]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-15 02:42:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 04:07:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494816158053360,
"parent_rev": "79f466d744b7c279c939c27877ae261d02f966b2", "commit_rev":
"b8cc19e2ca0b494668eb91df0eb054f3d94b639e"}

[commit-bot: I haz the power, 2017-05-15 04:07:16]

Description was changed from

==========
[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks] Make dragging update selected items.

This CL makes the bookmark list select the item that's being dragged if
it isn't already selected and deselects the existing set if it doesn't
include the drag item.

BUG=692843
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2871573004
Cr-Commit-Position: refs/heads/master@{#471657}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8cc19e2ca0b494668eb91df0eb0...
==========

[commit-bot: I haz the power, 2017-05-15 04:07:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8cc19e2ca0b494668eb91df0eb0...