|
|
Created:
3 years, 7 months ago by Ivan Šandrk Modified:
3 years, 7 months ago Reviewers:
Devlin CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Test] Added a test for activeTab URL filtering
Added a test to make sure that changes introduced in crrev.com/2858643002 to ExtensionActionAPI::DispatchExtensionActionClicked work as intended, ie. that the extension doesn't have access to tab.url unless it has the activeTab permission granted.
TEST=This test succeeds with the aforementioned crrev patch, and fails without it.
BUG=709513
Review-Url: https://codereview.chromium.org/2871533002
Cr-Commit-Position: refs/heads/master@{#474979}
Committed: https://chromium.googlesource.com/chromium/src/+/de08ac6f6973f9771eb912e816d046abc791ac54
Patch Set 1 #Patch Set 2 : Added a public session test (tests URL scrubbing) #
Total comments: 6
Patch Set 3 : Rebase #Patch Set 4 : Comments, nits, ScopedTestPublicSessionLoginState #
Messages
Total messages: 32 (25 generated)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
isandrk@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Hey Devlin, ptal! I promise these reviews will dry up soon :-)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:20001) has been deleted
Sorry for the delay on this. If it's okay, I'd like to wait 'til we're sure how https://codereview.chromium.org/2858013002/ will shake out before we add much more activeTab logic? if you'd prefer to land this sooner, though, I can take a look.
https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... File chrome/test/data/extensions/api_test/active_tab/background.js (right): https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:49: if (runCount == 1) { add some comments explaining the ordering here. https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:50: assertTrue(tab.url == undefined); maybe just: assertFalse(!!tab.url); https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:51: return chrome.test.succeed(); chrome.test.succeed() doesn't return anything, so prefer: chrome.test.succeed(); return;
The CQ bit was checked by isandrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... File chrome/test/data/extensions/api_test/active_tab/background.js (right): https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:49: if (runCount == 1) { On 2017/05/23 20:49:21, Devlin (catching up) wrote: > add some comments explaining the ordering here. Done. https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:50: assertTrue(tab.url == undefined); On 2017/05/23 20:49:21, Devlin (catching up) wrote: > maybe just: assertFalse(!!tab.url); Done. https://codereview.chromium.org/2871533002/diff/60001/chrome/test/data/extens... chrome/test/data/extensions/api_test/active_tab/background.js:51: return chrome.test.succeed(); On 2017/05/23 20:49:21, Devlin (catching up) wrote: > chrome.test.succeed() doesn't return anything, so prefer: > chrome.test.succeed(); > return; Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by isandrk@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495790478090050, "parent_rev": "1c831a5af48331b017f2bf3d6a07abb40f143626", "commit_rev": "de08ac6f6973f9771eb912e816d046abc791ac54"}
Message was sent while issue was closed.
Description was changed from ========== [Test] Added a test for activeTab URL filtering Added a test to make sure that changes introduced in crrev.com/2858643002 to ExtensionActionAPI::DispatchExtensionActionClicked work as intended, ie. that the extension doesn't have access to tab.url unless it has the activeTab permission granted. TEST=This test succeeds with the aforementioned crrev patch, and fails without it. BUG=709513 ========== to ========== [Test] Added a test for activeTab URL filtering Added a test to make sure that changes introduced in crrev.com/2858643002 to ExtensionActionAPI::DispatchExtensionActionClicked work as intended, ie. that the extension doesn't have access to tab.url unless it has the activeTab permission granted. TEST=This test succeeds with the aforementioned crrev patch, and fails without it. BUG=709513 Review-Url: https://codereview.chromium.org/2871533002 Cr-Commit-Position: refs/heads/master@{#474979} Committed: https://chromium.googlesource.com/chromium/src/+/de08ac6f6973f9771eb912e816d0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as https://chromium.googlesource.com/chromium/src/+/de08ac6f6973f9771eb912e816d0... |