Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 2871503003: Worklet: Move common code from Worker/WorkletGlobalScope to WorkerOrWorkletGlobalScope (Closed)

Created:
3 years, 7 months ago by nhiroki
Modified:
3 years, 7 months ago
Reviewers:
falken, kinuko, bashi
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move common code among Worker/WorkletGlobalScope to WorkerOrWorkletGlobalScope For cleanup, this CL factors out WorkerOrWorkletScriptController from WorkerGlobalScope and WorkletGlobalScope to WorkerOrWorkletGlobalScope. This cleanup is useful for implementing ExecutionContext::CanExecuteScripts on WorkerOrWorkletGlobalScope that's necessary for module loading. BUG=627945 Review-Url: https://codereview.chromium.org/2871503003 Cr-Commit-Position: refs/heads/master@{#470204} Committed: https://chromium.googlesource.com/chromium/src/+/08ce463ab55e4d777f21f394a78cefaaa5a777f1

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix rebase failure #

Messages

Total messages: 35 (24 generated)
nhiroki
PTAL, thanks!
3 years, 7 months ago (2017-05-08 23:30:34 UTC) #12
kinuko
lgtm if bots become happy
3 years, 7 months ago (2017-05-08 23:58:14 UTC) #14
nhiroki
On 2017/05/08 23:58:14, kinuko wrote: > lgtm if bots become happy Thank you! Rebased the ...
3 years, 7 months ago (2017-05-09 00:03:55 UTC) #16
nhiroki
+bashi@, can you review changes under bindings/? This just adds header inclusions. Thanks!
3 years, 7 months ago (2017-05-09 00:05:23 UTC) #18
bashi
bindings/ lgtm
3 years, 7 months ago (2017-05-09 00:21:57 UTC) #22
falken
lgtm 2
3 years, 7 months ago (2017-05-09 00:25:18 UTC) #23
nhiroki
Thank you!
3 years, 7 months ago (2017-05-09 00:29:00 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871503003/60001
3 years, 7 months ago (2017-05-09 00:40:23 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/448289)
3 years, 7 months ago (2017-05-09 01:24:21 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871503003/60001
3 years, 7 months ago (2017-05-09 01:27:07 UTC) #32
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:28:35 UTC) #35
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/08ce463ab55e4d777f21f394a78c...

Powered by Google App Engine
This is Rietveld 408576698