Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: media/filters/video_decoder_selector_unittest.cc

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Remove ScopedVector from audio/video render related code in media/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_decoder_selector_unittest.cc
diff --git a/media/filters/video_decoder_selector_unittest.cc b/media/filters/video_decoder_selector_unittest.cc
index 5b00a6e876bebf270a3105632671593a490b0618..444be6a2ea7a08b94aeddb98a4e71c42a5dbe99b 100644
--- a/media/filters/video_decoder_selector_unittest.cc
+++ b/media/filters/video_decoder_selector_unittest.cc
@@ -4,10 +4,10 @@
#include <stddef.h>
#include <utility>
-#include <vector>
#include "base/bind.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "build/build_config.h"
@@ -58,8 +58,8 @@ class VideoDecoderSelectorTest : public ::testing::Test {
new StrictMock<MockDemuxerStream>(DemuxerStream::VIDEO)),
decoder_1_(new StrictMock<MockVideoDecoder>(kDecoder1)),
decoder_2_(new StrictMock<MockVideoDecoder>(kDecoder2)) {
- all_decoders_.push_back(decoder_1_);
- all_decoders_.push_back(decoder_2_);
+ all_decoders_.push_back(base::WrapUnique(decoder_1_));
+ all_decoders_.push_back(base::WrapUnique(decoder_2_));
// |cdm_context_| and |decryptor_| are conditionally created in
// InitializeDecoderSelector().
}
@@ -84,7 +84,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
TestVideoConfig::NormalEncrypted());
}
- ScopedVector<VideoDecoder> CreateVideoDecodersForTest() {
+ std::vector<std::unique_ptr<VideoDecoder>> CreateVideoDecodersForTest() {
return std::move(all_decoders_);
}
@@ -167,7 +167,7 @@ class VideoDecoderSelectorTest : public ::testing::Test {
StrictMock<MockVideoDecoder>* decoder_1_;
StrictMock<MockVideoDecoder>* decoder_2_;
- ScopedVector<VideoDecoder> all_decoders_;
+ std::vector<std::unique_ptr<VideoDecoder>> all_decoders_;
std::unique_ptr<VideoDecoder> selected_decoder_;
base::MessageLoop message_loop_;

Powered by Google App Engine
This is Rietveld 408576698