Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Unified Diff: media/base/decoder_factory.h

Issue 2871503002: Remove ScopedVector from audio/video renderer related code in media/ (Closed)
Patch Set: Remove ScopedVector from audio/video render related code in media/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/decoder_factory.cc » ('j') | media/filters/audio_decoder_selector_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/decoder_factory.h
diff --git a/media/base/decoder_factory.h b/media/base/decoder_factory.h
index 06df353439d15b4f9c0c8de58e4a82911c7f53a1..6d073401e043dd4504929691597c4cc66e70df3a 100644
--- a/media/base/decoder_factory.h
+++ b/media/base/decoder_factory.h
@@ -5,9 +5,12 @@
#ifndef MEDIA_BASE_DECODER_FACTORY_H_
#define MEDIA_BASE_DECODER_FACTORY_H_
+#include <memory>
+#include <vector>
+
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
xhwang 2017/05/10 16:41:24 Not needed in this header file. In .cc files where
xiaofengzhang 2017/05/11 06:34:43 Done. Thanks!
#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_vector.h"
#include "media/base/media_export.h"
namespace base {
@@ -30,14 +33,14 @@ class MEDIA_EXPORT DecoderFactory {
// Decoders are single-threaded, each decoder should run on |task_runner|.
virtual void CreateAudioDecoders(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
- ScopedVector<AudioDecoder>* audio_decoders);
+ std::vector<std::unique_ptr<AudioDecoder>>* audio_decoders);
// Creates video decoders and append them to the end of |video_decoders|.
// Decoders are single-threaded, each decoder should run on |task_runner|.
virtual void CreateVideoDecoders(
scoped_refptr<base::SingleThreadTaskRunner> task_runner,
GpuVideoAcceleratorFactories* gpu_factories,
- ScopedVector<VideoDecoder>* video_decoders);
+ std::vector<std::unique_ptr<VideoDecoder>>* video_decoders);
private:
DISALLOW_COPY_AND_ASSIGN(DecoderFactory);
« no previous file with comments | « no previous file | media/base/decoder_factory.cc » ('j') | media/filters/audio_decoder_selector_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698