Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2871493002: cros: Add UMA metrics in encryption migration UI. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Add UMA metrics in encryption migration UI. Some metrics about encryption migration are already recorded in cryptohomed. In this CL, I'd like to add following UI-related UMA metrics on the app. Cryptohome.MigrationUI.FirstScreen Cryptohome.MigrationUI.UserChoice Cryptohome.MigrationUI.ConsumedBatteryPercent BUG=714887 TEST=Disable reboot after the migration by modifying the code, and check that chrome://histograms shows the added metrics. Review-Url: https://codereview.chromium.org/2849833002 Cr-Commit-Position: refs/heads/master@{#468241} (cherry picked from commit b75aa7267969141e12f5ece554be20d81d39b044) Review-Url: https://codereview.chromium.org/2871493002 . Cr-Commit-Position: refs/branch-heads/3071@{#444} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3db95f093b5dd7c3924a74b577a60a3b12e1f968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 6 chunks +52 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 7 months ago (2017-05-08 07:32:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3db95f093b5dd7c3924a74b577a60a3b12e1f968.

Powered by Google App Engine
This is Rietveld 408576698