GRC: Added Tab coordination units behind a feature flag

GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals through.

BUG=691886
Review-Url: https://codereview.chromium.org/2871353002
Cr-Commit-Position: refs/heads/master@{#472817}
Committed: https://chromium.googlesource.com/chromium/src/+/8c8d3b706a58e5772fd8ff31001abeccc94a3fa5

[oystein (OOO til 10th of July), 2017-05-10 21:18:11]

Description was changed from

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.
==========

to

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.

BUG=691886
==========

[oystein (OOO til 10th of July), 2017-05-10 21:30:41]

oysteine@chromium.org changed reviewers:
+ nasko@chromium.org, rockot@chromium.org, thestig@chromium.org

[oystein (OOO til 10th of July), 2017-05-10 21:31:18]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[oystein (OOO til 10th of July), 2017-05-10 21:32:21]

ptal!

[commit-bot: I haz the power, 2017-05-10 21:33:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:24:57]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[zhenw, 2017-05-10 22:52:08]

Description was changed from

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.

BUG=691886
==========

to

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.

BUG=691886
==========

[Lei Zhang, 2017-05-10 23:53:19]

You have red bots...

I'm guessing you want me to review chrome, nasko for content, and rockot for
services?

[Lei Zhang, 2017-05-10 23:59:01]

Is GRC desktop-only or "OS-All" ?

Is this something users should be able to toggle via about:flags?

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
File
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
(right):

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h:40:
DISALLOW_COPY_AND_ASSIGN(ResourceCoordinatorWebContentsObserver);
nit: blank line above.

[nasko, 2017-05-11 22:24:14]

The content/ bits look mostly plumbing for the service. I'd defer to Ken on
those bits and happy to stamp once he is ok with the CL.

[oystein (OOO til 10th of July), 2017-05-11 22:28:15]

On 2017/05/10 at 23:53:19, thestig wrote:
> You have red bots...
> 
> I'm guessing you want me to review chrome, nasko for content, and rockot for
services?

Looking into the Android dependency issues, but yep, sorry, that's basically the
review load (rockot@ for fact that I'm hooking up the embedded Mojo service).

GRC is OS-All, though the first few use-cases are related to multiple tabs and
will be more relevant for desktop initially.

I don't think there'd be much use right now for users to toggle this on via
about:flags; I suspect we'll want that once we add specific policies for
discarding background tabs / delaying background loads, etc.

[Ken Rockot(use gerrit already), 2017-05-11 22:41:21]

servicey stuff all LGTM

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:3646:
"//services/resource_coordinator/public/cpp:resource_coordinator_cpp",
this is explicitly a non-Android block, hence yer deps issue

[oystein (OOO til 10th of July), 2017-05-11 22:50:57]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 22:52:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oystein (OOO til 10th of July), 2017-05-11 22:52:47]

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:3646:
"//services/resource_coordinator/public/cpp:resource_coordinator_cpp",
On 2017/05/11 at 22:41:21, Ken Rockot wrote:
> this is explicitly a non-Android block, hence yer deps issue

I have brought shame upon my family :(.

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
File
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
(right):

https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h:40:
DISALLOW_COPY_AND_ASSIGN(ResourceCoordinatorWebContentsObserver);
On 2017/05/10 at 23:59:00, Lei Zhang (OOO) wrote:
> nit: blank line above.

Done.

[commit-bot: I haz the power, 2017-05-12 00:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 00:42:17]

Dry run: This issue passed the CQ dry run.

[oystein (OOO til 10th of July), 2017-05-15 16:16:13]

On 2017/05/11 at 22:52:47, oystein wrote:
> https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn
> File chrome/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/BUILD.gn...
> chrome/browser/BUILD.gn:3646:
"//services/resource_coordinator/public/cpp:resource_coordinator_cpp",
> On 2017/05/11 at 22:41:21, Ken Rockot wrote:
> > this is explicitly a non-Android block, hence yer deps issue
> 
> I have brought shame upon my family :(.
> 
>
https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
> File
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
(right):
> 
>
https://codereview.chromium.org/2871353002/diff/40001/chrome/browser/resource...
>
chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h:40:
DISALLOW_COPY_AND_ASSIGN(ResourceCoordinatorWebContentsObserver);
> On 2017/05/10 at 23:59:00, Lei Zhang (OOO) wrote:
> > nit: blank line above.
> 
> Done.

thestig: gentle ping :)

[Lei Zhang, 2017-05-15 19:00:03]

lgtm

[oystein (OOO til 10th of July), 2017-05-15 21:10:26]

On 2017/05/15 at 19:00:03, thestig wrote:
> lgtm

thanks!

One remaining gentle ping to nasko@ for stamping :)

[oystein (OOO til 10th of July), 2017-05-17 17:37:13]

oysteine@chromium.org changed reviewers:
+ creis@chromium.org

[oystein (OOO til 10th of July), 2017-05-17 17:37:29]

On 2017/05/15 at 21:10:26, oystein wrote:
> On 2017/05/15 at 19:00:03, thestig wrote:
> > lgtm
> 
> thanks!
> 
> One remaining gentle ping to nasko@ for stamping :)

+creis for content/ as nasko is OOO

[Charlie Reis, 2017-05-17 19:00:08]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2017-05-17 19:00:08]

Passing to nick@ to give a stamp, since I don't have a good sense for this.

[ncarter (slow), 2017-05-17 19:09:21]

lgtm

[oystein (OOO til 10th of July), 2017-05-17 20:57:10]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2017-05-17 20:57:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2871353002/#ps60001
(title: "Review/build fixes")

[commit-bot: I haz the power, 2017-05-17 20:59:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:07:42]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oystein (OOO til 10th of July), 2017-05-17 22:13:03]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 22:14:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 02:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 02:16:36]

Dry run: This issue passed the CQ dry run.

[oystein (OOO til 10th of July), 2017-05-18 04:43:13]

The CQ bit was checked by oysteine@chromium.org

[oystein (OOO til 10th of July), 2017-05-18 04:43:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, rockot@chromium.org, nick@chromium.org
Link to the patchset: https://codereview.chromium.org/2871353002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-18 04:44:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 04:58:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[oystein (OOO til 10th of July), 2017-05-18 05:05:14]

oysteine@chromium.org changed reviewers:
+ dcheng@chromium.org

[oystein (OOO til 10th of July), 2017-05-18 05:05:38]

+dcheng as it seems like the manifest.json changes need a security lgtm too.

[dcheng, 2017-05-18 09:42:44]

manifest lgtm

[oystein (OOO til 10th of July), 2017-05-18 15:11:19]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2017-05-18 15:12:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 15:18:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495120279224900,
"parent_rev": "d77ddd837aa283b69cae1e6d109e304c203648b9", "commit_rev":
"8c8d3b706a58e5772fd8ff31001abeccc94a3fa5"}

[commit-bot: I haz the power, 2017-05-18 15:18:33]

Description was changed from

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.

BUG=691886
==========

to

==========
GRC: Added Tab coordination units behind a feature flag

This also hooks up the GRC service itself, and sends tab visibility signals
through.

BUG=691886

Review-Url: https://codereview.chromium.org/2871353002
Cr-Commit-Position: refs/heads/master@{#472817}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c8d3b706a58e5772fd8ff31001a...
==========

[commit-bot: I haz the power, 2017-05-18 15:18:35]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8c8d3b706a58e5772fd8ff31001a...